Repository navigation
fix: sorting after a combined deploy, files with %XX in their name - #51
Merged
Merged
Conversation
Sorting: PR #50 changed the site and the API in one push, so the Pages and API workflows started together and the mirror read the old Worker, which had no listing.json. The site fell back to the fixed pages, where the sort selector changed nothing. - api.yml starts the Pages deploy after the Worker is live, so the mirror always reads the new one (actions: write, deploy job only). - Without listing.json the selector is hidden instead of doing nothing. Names with a literal escape, e.g. bmp280%2Bbme280_lilka.lua: Keira and the site request the name as written, Pages decodes it and looked for bmp280+bme280_lilka.lua, a 404 (also on the old build.py site). The mirror now also writes the decoded copy; only the file name is decoded, never into another path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting: PR #50 changed the site and the API in one push, so the Pages and API workflows started together and the mirror read the old Worker, which had no listing.json. The site fell back to the fixed pages, where the sort selector changed nothing.
Names with a literal escape, e.g. bmp280%2Bbme280_lilka.lua: Keira and the site request the name as written, Pages decodes it and looked for bmp280+bme280_lilka.lua, a 404 (also on the old build.py site). The mirror now also writes the decoded copy; only the file name is decoded, never into another path.