Repository navigation
Drain checkpoint readers before deciding final sealed state - #84
Merged
Merged
Conversation
Address issue 70 without exempting holders or extending the capture budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean Codex exit could be classified as a crash while the runner's own checkpoint capture still held a database. Move the existing holder scan into Checkpointer.final after the in-flight capture drains and before the final capture starts. All observed holders still prevent sealing, and scanning consumes the existing final-capture budget. Unclean exits remain crash candidates; stalled captures still skip final publication.
Closes #70.
Validation at 7730000:
Evidence: /global/scratch/fsa/fc_jevons/ligon/burst/sucoder-issue70-9j44nb32/ contains test-head, import-path, full.log and full.xml. The initial local suite was deliberately interrupted after 15 passes to keep native acceptance outside the managed coordinator.
The prior-art ledger records invariants and direct callers. GitNexus impact/change detection could not load libssl.so.3; manual caller/diff review was used. Self-reviewed; no independent review. No holder exemption, timeout increase, or placement/recovery-policy relaxation.