Repository navigation
Preserve SHA-only source commits in dispatch snapshots - #83
Merged
Merged
Conversation
Address issue 82 with exact-commit local fetching and loose/packed regression coverage. Record dispatch backlog dispositions and remaining acceptance work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid commit fetched without a source ref passed dispatch dry-run but disappeared from the transport-cloned snapshot, causing submission to fail before Slurm (issue 82). Fetch the already-resolved SHA from the explicit local source into the private result repository before its existing commit check and branch update. Reuse sanitized file-only transport and the staging timeout; source refs/config/index remain unchanged. Pool local-copy staging retains its existing path.
Validation: both loose and packed SHA-only regressions fail on unchanged main d2556f0 and pass with the fix. They verify the selected tree, private branch, connectivity and unchanged source file bytes. Additional error/timeout cases verify staging never reaches the scheduler. All 387 dispatch tests pass; after rebasing onto merged PR 80 (c09d361), all four new cases pass again. No new full-suite or native-worker run was needed for this pre-scheduler defect.
The included dispatch backlog report assesses all six related issues, supplies closure/residual drafts for 72, 79 and 77, and keeps 70 and 76 separate. No issue tracker edits or closures were applied. PR 80 was merged separately at the user's request.
Self-review and the dispatch ledger bound the production change to dispatch.submit. GitNexus impact/change detection were attempted but unavailable because its native library cannot load libssl.so.3; manual caller and diff review were used. No independent review is claimed.