mod_cgi: honor rejected CGI header collisions - #170
Open
deprrous wants to merge 1 commit into
Open
Conversation
Member
|
@copilot unassign and go away. you are an unwelcome reviewer. do not respond or add any more noise. |
Member
|
@deprrous it was inappropriate to post this publicly after you were told that an AI-generated patch or writeup was not necessary to provide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_cgi_headers()already rejects request headers that collide after CGI environment normalization, butmod_cgiignored that return value and kept building the child environment.FastCGI, SCGI, and SSI already stop on that helper result. This makes direct CGI do the same, preserves the
400 Bad Requestpath instead of falling through to the generic500, and adds a focused regression for theX-Forwarded-For/X-Forwarded_Forcollision.Validation:
cmake -S . -B build/lighttpd-pr-cgi-header-conflictcmake --build build/lighttpd-pr-cgi-header-conflict -j4cmake --build build/lighttpd-pr-cgi-header-conflict --target test -- -j4git diff --check