Repository navigation
multi: migrate to btcd v2 modules - #860
Merged
Merged
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
ellemouton
force-pushed
the
ellemouton/btcd-v2-migration
branch
from
July 6, 2026 15:20
1e97339 to
72cbf6f
Compare
ellemouton
force-pushed
the
ellemouton/btcd-v2-migration
branch
from
July 6, 2026 20:00
72cbf6f to
03782bb
Compare
ellemouton
marked this pull request as ready for review
July 6, 2026 20:30
ellemouton
force-pushed
the
ellemouton/btcd-v2-migration
branch
3 times, most recently
from
July 6, 2026 21:37
41ed5da to
8eb94ae
Compare
Migrate the main module to the per-package btcd v2 modules introduced by btcd v0.26.0. The monolithic btcd packages were split into their own /v2 modules and v0.26.0 removed the old paths: wire, txscript, chaincfg, chaincfg/chainhash, btcutil and btcutil/psbt each move to their /v2 module (chainhash and psbt to the top level). The address-handling symbols (Address, DecodeAddress, NewAddress*, Hash160) moved out of btcutil into a new address package, imported as btcaddr to avoid shadowing local "address" variables. btcwallet v0.18.0 added SubmitPackage to chain.Interface, so EsploraChainService gains a SubmitPackage method that returns a not-supported error (Esplora has no package-relay endpoint). go directive bumped to 1.26.0 (btcec/v2 v2.5.0 needs Go 1.25+). All dependencies are pinned to their merged upstream commits: lndclient (PR #280) and taproot-assets + taprpc (PR #2186). No fork replaces.
lnd's invoicesrpc.AddInvoice unconditionally dereferences ChanDB.FetchAllChannels while assembling hop hints. The swap invoice generator builds invoices from explicit caller-provided route hints and has no backing channel database, so it passed ChanDB: nil, which panics against lnd master. Provide a mockChanDB reporting an empty channel set, mirroring the existing mockGraph stub.
ellemouton
force-pushed
the
ellemouton/btcd-v2-migration
branch
from
July 6, 2026 22:13
8eb94ae to
efa8993
Compare
The bumped lndclient enforces a higher minimum connected-lnd version
(>= v0.21.0). The itest/systest harness pinned lnd
daily-testing-20260115, which predates that and is rejected at client
setup ("error checking connected lnd version"). Bump the default LND
image to a daily-testing build matching the lnd master the module now
tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates darepo-client to the per-package btcd v2 modules introduced by btcd
v0.26.0, letting the client consumeWalletKit.SubmitPackage(lndclient #280)for lnd-backed v3/TRUC package relay.
What changed
wire → wire/v2,txscript → txscript/v2,chaincfg → chaincfg/v2,chaincfg/chainhash → chainhash/v2,btcutil → btcutil/v2,btcutil/psbt → psbt/v2; address symbols →address/v2(aliasedbtcaddr).btcjson,rpcclient,blockchain,btcec/v2stay in the root module.EsploraChainService.SubmitPackage— btcwalletv0.18.0addedSubmitPackageto
chain.Interface; the Esplora backend returns a not-supported error.v2.5.0needs Go 1.25+); btcwalletv0.18.0, neutrinov0.18.0, lnd master.Dependencies
None — all upstream, no fork replaces. The full btcd-v2 chain is merged:
lndclient #280,
aperture #244, and
taproot-assets #2186;
all pinned to their merged upstream commits. Builds green (
go build ./...).