Skip to content

build: migrate v0.8 to btcd v2 modules - #2366

Open
hieblmi wants to merge 7 commits into
lightninglabs:v0.8from
hieblmi:hai/v0.8-btcd-v2
Open

hieblmi wants to merge 7 commits into
lightninglabs:v0.8from
hieblmi:hai/v0.8-btcd-v2

Conversation

@hieblmi

@hieblmi hieblmi commented Oct 21, 2026 •

Copy link
Copy Markdown

Provide a btcd v2 compatibility branch based on the fixed v0.8.6 release for Loop #1199 and LiT #1438. Retain the released RFQ, address, proof, and patched TLV fixes rather than switching to main's different API and incomplete v0.8.6 fix set. Exported Bitcoin Go types change, and source builds require Go 1.26.8.

Use lndclient v0.21.0-3 and lnd revision f2963ce1fd19, preserving the released v0.21.4 forwarding-response recovery and replay fixes. Align SQL, fn, queue, protobuf, wallet, and chain dependencies. Recognize pgx v5 serialization errors so conflicting PostgreSQL transactions retry correctly.

Migrate the patched TLV module, adapt the remote-signer harness to lnd's watch-only helper, and keep RFQ cases under the integration build constraint. Make the asynchronous cache deadline regression deterministic. Restore the downloaded integrated test daemon's execute permission in the standard, remote-signer, and PostgreSQL jobs.

Validation passes for the full dev/nolog unit suite, patched TLV race suite, focused encoding/database/proof race regressions, PostgreSQL conflict/cache checks, integration-package compilation, configured lint, module checks, and build-version checks. The workflow fix also passes YAML parsing and executable-coverage checks.

Loop and LiT pin runtime revision b47086671590; the later 6905f7ec follow-up changes only CI executable permissions.

Remaining integration issues:

  • Custom-channel invoice payments can convert 1,000 requested units to 999 sent units, leaving the invoice partially paid until timeout. The same failing calculation and lnd call path are present in the released sources; released-baseline runtime behavior has not been reproduced. These failures also occur before the recovery update.
  • The v0.8.0 compatibility case times out waiting for a funding acknowledgement; the v0.8.4 upgrade case passes. The same timeout occurs before the recovery update.

Temporary fork pins must be replaced with accepted upstream revisions or releases before the coordinated release. This PR does not change an existing release tag.

@hieblmi
hieblmi marked this pull request as ready for review October 21, 2026 11:14
Use the btcd v2 revision containing released forwarding recovery and invoice replay fixes, along with matching SQL, fn, and queue modules. Align the protobuf fork and Go 1.26.8 daemon builders while preserving the patched TLV module and fixed v0.8.6 source.
Artifact downloads reset executable bits. Restore the integrated tapd
binary alongside the other test binaries in the standard, remote-signer
and PostgreSQL jobs so RFQ tests can start it.

This fixes permission-denied failures that also occurred before the lnd
recovery dependency update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

2 participants