Skip to content

tapfeatures: require negotiated-chan-cfg feature bit - #2288

Draft
GeorgeTsagk wants to merge 1 commit into
lightninglabs:mainfrom
GeorgeTsagk:negotiated-chan-cfg-required
Draft

GeorgeTsagk wants to merge 1 commit into
lightninglabs:mainfrom
GeorgeTsagk:negotiated-chan-cfg-required

Conversation

@GeorgeTsagk

Copy link
Copy Markdown
Member

Description

Phase 2 of #2278. This is only the feature bit flip and is scheduled for
v0.10, nothing else in here.

negotiated-chan-cfg moves from optional to required in ourFeatures().
Peers that don't signal it (every version before v0.9.0) are disconnected at
init by checkRequiredBits, and the funding controller rejects them with
ErrNegotiatedChanCfgRequired as a second line of defence. The fallback to
zeroed channel configs for the initial commitment goes away with it, both
sides now always derive it from the negotiated configs.

The two guard tests that pinned the bit as optional now pin it as required.

Draft until v0.9.0 is tagged: compatVersions in the backwards compat itest
still lists v0.8.0, which this PR rejects by design, so Compat Tests
fails until that list is bumped to a version that signals the bit.

@GeorgeTsagk GeorgeTsagk added this to the v0.10 milestone Sep 7, 2026
@GeorgeTsagk
GeorgeTsagk force-pushed the negotiated-chan-cfg-required branch from 45c8e07 to 15a43f1 Compare September 7, 2026 09:43
@jtobin jtobin linked an issue Sep 7, 2026 that may be closed by this pull request
Peers that don't signal the feature derive the initial commitment from
zeroed channel configs, which no longer matches what we build. Rejecting
them at init replaces the fallback that was in place for one release.
@GeorgeTsagk
GeorgeTsagk force-pushed the negotiated-chan-cfg-required branch from 15a43f1 to 8b01615 Compare October 12, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

tapfeatures: make negotiated-chan-cfg required

1 participant