Repository navigation
tapfeatures: require negotiated-chan-cfg feature bit - #2288
Draft
GeorgeTsagk wants to merge 1 commit into
Draft
GeorgeTsagk wants to merge 1 commit into
GeorgeTsagk wants to merge 1 commit into
Conversation
GeorgeTsagk
force-pushed
the
negotiated-chan-cfg-required
branch
from
September 7, 2026 09:43
45c8e07 to
15a43f1
Compare
Peers that don't signal the feature derive the initial commitment from zeroed channel configs, which no longer matches what we build. Rejecting them at init replaces the fallback that was in place for one release.
GeorgeTsagk
force-pushed
the
negotiated-chan-cfg-required
branch
from
October 12, 2026 09:22
15a43f1 to
8b01615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Phase 2 of #2278. This is only the feature bit flip and is scheduled for
v0.10, nothing else in here.
negotiated-chan-cfgmoves from optional to required inourFeatures().Peers that don't signal it (every version before v0.9.0) are disconnected at
init by
checkRequiredBits, and the funding controller rejects them withErrNegotiatedChanCfgRequiredas a second line of defence. The fallback tozeroed channel configs for the initial commitment goes away with it, both
sides now always derive it from the negotiated configs.
The two guard tests that pinned the bit as optional now pin it as required.
Draft until v0.9.0 is tagged:
compatVersionsin the backwards compat iteststill lists
v0.8.0, which this PR rejects by design, soCompat Testsfails until that list is bumped to a version that signals the bit.