Repository navigation
Immediate force-close itest - #2177
Conversation
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
4558394 to
b8bb5a4
Compare
|
/gemini summary |
Summary of ChangesThis pull request introduces a new integration test to validate the edge case of force-closing a tap channel immediately after funding. To support this, the PR includes critical updates to the auxiliary funding and sweeping logic, ensuring that commitment output allocations and BTC balances are correctly calculated to maintain consistency with on-chain commitment transactions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Activity
|
662ba4e to
d19e3b2
Compare
jtobin
left a comment
There was a problem hiding this comment.
(Pretty sure this one LGTM, just holding off on further review/approval until the upstream lnd PR lands.)
d19e3b2 to
17b5586
Compare
|
@GeorgeTsagk, remember to re-request review from reviewers when ready |
2 similar comments
|
@GeorgeTsagk, remember to re-request review from reviewers when ready |
|
@GeorgeTsagk, remember to re-request review from reviewers when ready |
|
@GeorgeTsagk, remember to re-request review from reviewers when ready |
17b5586 to
7884011
Compare
7884011 to
f9e41a4
Compare
f9e41a4 to
6ae76b9
Compare
|
@jtobin: review reminder |
beec607
Description
Adds an itest edge-case where a tap channel is force closed immediately without any commitment updates.
Depends on lightningnetwork/lnd#10804 (merged) and is based on #2278, which gates the negotiated config derivation behind a feature bit so the backwards compat test keeps passing.