Repository navigation
multi: backport #187 and #188 for v0.1.1 - #191
Merged
Merged
Conversation
Preserve the concrete output locator supplied by tapd so callers can export the correct proof when a script key is reused. Keep both transports consistent and verify the locator against exported proofs. (cherry picked from commit 7b6d1a8)
Carry the wallet's complete key descriptor and Taproot tweak into backend-signed inputs, checking that they derive the proof's key. Correct the REST lookup encoding so both transports can resolve it. Cover received-asset spends through signing and proof import. (cherry picked from commit 306bc55)
Earlier tests can leave miner outputs that cover the child fee but produce dust change. Select an output that also leaves standard change so the package is accepted regardless of wallet history. (cherry picked from commit 13bc1df)
tapAssetScriptKey normalizes the wallet's key to even parity, so an odd-parity proof key would be swapped for its twin. Keep the proof's key and give each failed check its own error with the keys involved. (cherry picked from commit 7fe28aa)
The gateway decodes bytes path parameters as base64, so a hex internal key failed to decode. Match the script-key lookup's encoding. (cherry picked from commit 25072fd)
List the anchor outpoint field and the received-input signing and REST lookup fixes in the 0.1.1 entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #187 and #188 from
mainto thev0.1line, so that the v0.1.1 release includes them, and adds both to the 0.1.1 changelog entry.AssetRecord.AnchorOutpoint, which Loop's swapkit needs to export the exact proof for a reused script key.Commits
Each commit is a
git cherry-pick -xof itsmaincommit, with the btcd v2 imports rewritten to the v1 paths in the same commit, so every commit builds on its own. Authorship is kept.wallet: expose anchor outpoints in asset records (#187)from 7b6d1a8customanchor: resolve received asset signing metadatafrom 306bc55itest: avoid dust change in P2A fee-bump transactionsfrom 13bc1dfcustomanchor: keep proof key when resolving signing metadatafrom 7fe28aarest: encode internal key path parameter as base64from 25072fdrelease: add backported fixes to v0.1.1adds the changes to the 0.1.1 entry inCHANGELOG.md.Commit 3 had one conflict, in the import block of
itest/custom_anchor_builder_test.go. The resolution keeps the v1 imports and addsgithub.com/btcsuite/btcd/mempool. Apart from import lines, each commit's diff is identical to its source onmain.The Go 1.26.8 and lnd/tlv v1.4.1 bump from #190 is not backported: this line stays on lnd/tlv v1.3.2 with the replacement from tapd v0.8.6.
Testing
go vet, including with-tags=itest.make itestpasses 49/49 against tapd v0.8.5 and lnd v0.21.4-beta over gRPC and REST, includingTestCustomAnchorBuilderReceivedAsset(375s).make unit-raceandmake lint(0 issues) pass, andgo mod tidy -diffreports no changes.go list -deps -test -tags=itest ./...contains no btcd v2 packages other thanbtcec/v2.tapsdk/copy removed and its imports pointed at this branch astap-sdk v0.1.1, builds and vets, and its swapkit unit tests pass.