Skip to content

multi: backport #187 and #188 for v0.1.1 - #191

Merged
darioAnongba merged 6 commits into
v0.1from
darioAnongba/v0.1.1-backports
Nov 2, 2026
Merged

darioAnongba merged 6 commits into
v0.1from
darioAnongba/v0.1.1-backports

Conversation

@darioAnongba

Copy link
Copy Markdown
Collaborator

This PR backports #187 and #188 from main to the v0.1 line, so that the v0.1.1 release includes them, and adds both to the 0.1.1 changelog entry.

Commits

Each commit is a git cherry-pick -x of its main commit, with the btcd v2 imports rewritten to the v1 paths in the same commit, so every commit builds on its own. Authorship is kept.

  1. wallet: expose anchor outpoints in asset records (#187) from 7b6d1a8
  2. customanchor: resolve received asset signing metadata from 306bc55
  3. itest: avoid dust change in P2A fee-bump transactions from 13bc1df
  4. customanchor: keep proof key when resolving signing metadata from 7fe28aa
  5. rest: encode internal key path parameter as base64 from 25072fd
  6. release: add backported fixes to v0.1.1 adds the changes to the 0.1.1 entry in CHANGELOG.md.

Commit 3 had one conflict, in the import block of itest/custom_anchor_builder_test.go. The resolution keeps the v1 imports and adds github.com/btcsuite/btcd/mempool. Apart from import lines, each commit's diff is identical to its source on main.

The Go 1.26.8 and lnd/tlv v1.4.1 bump from #190 is not backported: this line stays on lnd/tlv v1.3.2 with the replacement from tapd v0.8.6.

Testing

  • Each commit builds and passes go vet, including with -tags=itest.
  • make itest passes 49/49 against tapd v0.8.5 and lnd v0.21.4-beta over gRPC and REST, including TestCustomAnchorBuilderReceivedAsset (375s).
  • make unit-race and make lint (0 issues) pass, and go mod tidy -diff reports no changes.
  • go list -deps -test -tags=itest ./... contains no btcd v2 packages other than btcec/v2.
  • swapkit: Consolidate asset swaps on tap-sdk v0.1.1 loop#1225, with its tapsdk/ copy removed and its imports pointed at this branch as tap-sdk v0.1.1, builds and vets, and its swapkit unit tests pass.

sputn1ck and others added 6 commits November 2, 2026 21:08
Preserve the concrete output locator supplied by tapd so callers can
export the correct proof when a script key is reused. Keep both
transports consistent and verify the locator against exported proofs.

(cherry picked from commit 7b6d1a8)
Carry the wallet's complete key descriptor and Taproot tweak into
backend-signed inputs, checking that they derive the proof's key.
Correct the REST lookup encoding so both transports can resolve it.
Cover received-asset spends through signing and proof import.

(cherry picked from commit 306bc55)
Earlier tests can leave miner outputs that cover the child fee but
produce dust change. Select an output that also leaves standard
change so the package is accepted regardless of wallet history.

(cherry picked from commit 13bc1df)
tapAssetScriptKey normalizes the wallet's key to even parity, so an
odd-parity proof key would be swapped for its twin. Keep the proof's
key and give each failed check its own error with the keys involved.

(cherry picked from commit 7fe28aa)
The gateway decodes bytes path parameters as base64, so a hex internal
key failed to decode. Match the script-key lookup's encoding.

(cherry picked from commit 25072fd)
List the anchor outpoint field and the received-input signing and REST
lookup fixes in the 0.1.1 entry.
@darioAnongba darioAnongba self-assigned this Nov 2, 2026
@darioAnongba darioAnongba moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Nov 2, 2026
@darioAnongba
darioAnongba merged commit 8b1cbe2 into v0.1 Nov 2, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Taproot-Assets Project Board Nov 2, 2026
@darioAnongba
darioAnongba deleted the darioAnongba/v0.1.1-backports branch November 2, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants