Skip to content

[BAC-1420] Bump lnd to master 5617ee7e (drops pgx/v4) - #290

Closed
lucasnaman wants to merge 51 commits into
lightninglabs:masterfrom
IBEXDWM:lucasnaman/bac-1420-bump-lnd-latest-beta
Closed

lucasnaman wants to merge 51 commits into
lightninglabs:masterfrom
IBEXDWM:lucasnaman/bac-1420-bump-lnd-latest-beta

Conversation

@lucasnaman

Copy link
Copy Markdown

No description provided.

guggero and others added 30 commits October 26, 2023 10:13
mod+lightning+chainkit: update to lnd v0.17.1-beta.rc1 and expose GetBlockHeader
mod+lightning: update to lnd v0.17.1-beta final
[BTCP-50] change the block confirmation target
Signed-off-by: lucasnaman <96252786+lucasnaman@users.noreply.github.com>
Merge pull request #10 from IBEXDWM/ibex
lucasnaman and others added 21 commits August 12, 2025 13:11
admin-56: add Claude Code actions and project files
Pulls upstream lndclient up to lightninglabs/lndclient@1be689d and
preserves IBEX-specific customizations.

Security CVEs closed by this merge:
- CVE-2025-68121 (Critical, Go stdlib crypto/tls): Go toolchain bumped
  to 1.25.5 via upstream PR lightninglabs#264
- CVE-2025-52881, CVE-2025-52565 (High, runc): runc bumped from 1.2.0
  to 1.2.8 via upstream PRs lightninglabs#252 / lightninglabs#251

Other notable upstream changes pulled in:
- LND v0.19.0-beta -> v0.20.1-beta
- SubscribeSingleInvoice now returns the full unmarshalled Invoice
- ChannelInfo gains CustomChannelData
- Many addinvoice fixes (route hints, fallback addr, blinded paths,
  amp flag, hold-invoice arg validation)

Conflict resolutions (IBEX customizations preserved):
- README.md: kept IBEX release-tagging workflow alongside upstream's
  new lndclient<->lnd compatibility table
- invoices_client.go: adopted upstream's InvoiceUpdate shape
  (embedded Invoice + AmtPaid) and kept IBEX's AmtPaidMsat field for
  millisatoshi precision required by lnproxy
- lightning_client.go: adopted upstream's CustomChannelData additions
  (no IBEX-specific code conflicted)

Remaining open Datadog CVEs to address in a follow-up:
- CVE-2026-33815, CVE-2026-33816 (jackc/pgx/v5 5.7.4 -> 5.7.6+)
- CVE-2026-39883 (otel/sdk 1.35.0 -> 1.38.x+)
- CVE-2026-34040 (docker/docker 28.1.1 -> verify patched version)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Brings in CLAUDE.md, Claude review/PR-description workflows, and the
IBEX pull-request template that landed on master after this branch was
cut.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The merge bumped tools/Dockerfile golang from 1.24.6 to 1.26.0, which
rebuilt golangci-lint and now strictly enforces .golangci.yml's 80-col
lll limit on lines that have been over since the original IBEX
additions in 2024 (commit 1993ca7, "ibex req").

All 9 violations were in IBEX-extension methods/comments
(SendMany / EstimateFees / NewAddress interface + impl, ListChannels
extension, TimePref doc). Wrapped them under 80 cols. No behavior
change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
[BAC-325] merge upstream lightninglabs/lndclient master
Brings in 45 upstream commits since the last sync (1be689d), including
the lnd v0.21.0-beta bump, btcd v2 modules, MuSig2 combined nonces,
walletkit SubmitPackage/RemoveTransaction, route fee estimates and
invoice payment components.

Conflict: upstream added its own SendPaymentRequest.PaymentAddr
(*[32]byte) and only forwards it for manual (non-invoice) payments. The
IBEX fork had added PaymentAddr ([]byte) and forwards it, plus Amt, even
when an invoice is set. Resolution: drop the fork's duplicate field and
keep its behaviour on upstream's type.

Downstream callers that set PaymentAddr as []byte (ln-proxy) must switch
to *[32]byte when they bump lndclient.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…m-lndclient

[BAC-1377] Merge upstream lightninglabs/lndclient master (lnd v0.21.0-beta)
Bump the Go pins: go.mod and tools/go.mod to go 1.27.3, CI GO_VERSION
to 1.27.3, the tools image to golang:1.27.3-bookworm. go mod tidy is a
no-op for the root module.

Bump golangci-lint in tools/go.mod from v2.4.1 to v2.15.0; older
releases cannot read the Go 1.27 export data format. 2.15 ships
exhaustruct as exhaustruct_v5, so disable it next to the already
disabled exhaustruct to keep the configured linter set unchanged.

Fix what the newer linter raises: modernize (sync.WaitGroup.Go, any,
embedded struct literals, Type.Methods iteration) via its auto-fix, and
goconst with fakeMemo, subserverRouter and rpcEstimateFee constants.
Values and behaviour unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ient-to-go-1273

[BAC-1357] Upgrade lndclient to Go 1.27.3
lnd v0.21.0-beta.rc2.0.20260630214209-40c64f9db30d ->
v0.21.0-beta.rc2.0.20261028015304-5617ee7e2a09 (621 commits). lnd
master dropped jackc/pgx/v4 for v5, which clears govulncheck
GO-2026-5004 for services that depend on this fork. Tagged v0.21.x
betas are not an option: they still use btcd v1 modules while this
fork is already on btcd v2.

go build, go vet and go test ./... pass.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@lucasnaman

Copy link
Copy Markdown
Author

Opened against the wrong repository by mistake; this is intended for the IBEXDWM fork. Apologies for the noise.

@lucasnaman lucasnaman closed this Oct 28, 2026
@lucasnaman
lucasnaman deleted the lucasnaman/bac-1420-bump-lnd-latest-beta branch October 28, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants