Repository navigation
Conversation
The lnd project only supports its current and previous major release. The version check only enforces the minimum version requested by the caller, which can be lowered through the CheckVersion config option. Log a warning if the connected node passes that check but is older than the oldest version still supported by lnd, without refusing the connection. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Mark which entries of the compatibility matrix still require a supported version of lnd and describe the warning that is logged when connecting to an unsupported node. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
saubyk
force-pushed
the
warn-unsupported-lnd-version
branch
from
October 2, 2026 18:57
80e137a to
29fe877
Compare
|
@starius: review reminder |
5 similar comments
|
@starius: review reminder |
|
@starius: review reminder |
|
@starius: review reminder |
|
@starius: review reminder |
|
@starius: review reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lndproject only supports its current and previous major release (currentlyv0.21.xandv0.20.x).lndclientonly enforces the minimum version requested by the caller, and that minimum can be lowered throughLndServicesConfig.CheckVersion, so a user can end up running against an unsupportedlndwithout noticing.This PR makes that visible without changing who can connect:
oldestSupportedVersion(v0.20.0), a warning is logged. The connection is not refused, so projects that set their own minimum are unaffected.lndversion, and a short section describing the support policy and the warning.oldestSupportedVersionneeds to be bumped together withminimalCompatibleVersionwhen moving to a new majorlndrelease.With the default configuration on
masterthe warning never fires, because the default minimum (v0.21.0) is already above the supported floor. It only fires when a caller lowersCheckVersion.Testing
TestUnsupportedVersionWarningcovers a node below, at and above the supported floor.make buildequivalent (go build ./...),go test ./...andmake unit-racepass locally.make lintwas not run locally (no docker available); relying on CI for that.Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes. (not applicable)
🤖 Generated with Claude Code