Repository navigation
build: disable MPTCP listeners by default - #258
ziggie1984 wants to merge 1 commit into
Conversation
|
Independent native Linux listener differential for this PR is complete. At base commit 7226d87, the Faraday main module had no multipathtcp=0 override. With Go 1.27.3 and net.mptcp.enabled=1, the actual net.Listen("tcp") probe returned SO_PROTOCOL=262 (IPPROTO_MPTCP). Setting GODEBUG=multipathtcp=0 changed it to SO_PROTOCOL=6 (IPPROTO_TCP). At this PR head 5032db0, go list reports multipathtcp=0 and the same listener probe returns SO_PROTOCOL=6 by default. Explicit GODEBUG=multipathtcp=1 still returns 262, so the opt-in remains available. The probe uses the Faraday module's own go.mod and a real Linux socket. It does not exercise the kernel exploit. The complete base-versus-PR run and logs are here: https://github.com/lmtlssss/sc-bitcoin-lightning-acceptance/actions/runs/41938901075 This independently confirms the module-level mitigation on the actual listener protocol. Thanks for carrying the fix. |
Change
Disable Go's automatic MPTCP listener support for
faraday. Faraday does notintentionally configure or depend on MPTCP, so this restores ordinary TCP
listeners while retaining an explicit operator opt-in through
GODEBUG=multipathtcp=1.Go 1.24 and newer enable MPTCP listeners by default on supported Linux kernels.
MPTCP is a prerequisite for the Linux use-after-free path discussed in
lightningnetwork/lnd#11455
and mitigated for lnd in
lightningnetwork/lnd#11456.
Existing binaries
Operators can apply the same mitigation immediately, without rebuilding, by
starting
faradaywithGODEBUG=multipathtcp=0and restarting it. A patchedkernel is still required to fix the underlying kernel vulnerability; this change
removes the demonstrated MPTCP-listener prerequisite.
Validation
go mod tidy -diffgo test ./cmd/faradaymultipathtcp=0infaraday's effective Go defaults