Prepare Python wheel releases - #1041
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
This is pretty outside of my wheelhouse (ba dum tiss), and I was planning to sink a lot of my review bandwidth into https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/4872 in the coming days, so FYI my first impression is that it may take me a little while to get to this and then take a while to get up to speed on it. |
d2af3f8 to
dbe8999
Compare
Okay. Now reassigned @tankyleo as we'll need this for next week's release (worst case I just run the updated scripts locally without prior review). Rebased after #1040 landed. |
dbe8999 to
8fffe35
Compare
Build Python-ABI-independent wheels for supported Linux and macOS targets so users can install LDK Node directly from PyPI. Keep build and publication available through local scripts. Require the complete artifact set on TestPyPI before production, and exercise the bindings on the oldest and newest supported CPython versions. Co-Authored-By: HAL 9000
8fffe35 to
63a0d8b
Compare
|
Now also amended to allow building macOS x86_64 wheels on aarch64 macs. |
Assisted-by: OpenAI Codex
cibuildwheel copies the repository into its Linux build container. Ignored build outputs such as target/, virtual environments, and dist/ can make that context several gigabytes, slowing builds or exhausting Docker storage. Export tracked and non-ignored untracked files to a temporary source directory before invoking cibuildwheel. This keeps ignored artifacts out of the container context while preserving local changes for --allow-dirty builds. Assisted-by: OpenAI Codex
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Pushed a couple of commits on top of your branch that came up after a few rounds with codex, feel free to drop and amend as needed.
Yeah, def. disagree with adding |
913daec to
c12e087
Compare
Declare the dual-license expression and package both canonical license texts. Remove deprecated license classifiers so the SPDX expression is the authoritative declaration. Co-Authored-By: HAL 9000
a426172 to
6c51028
Compare
|
I successfully built and tested the Linux x86-64 wheel from this head across Python 3.10–3.14. The checksum and packaged license files look correct, and the publication validator rejects the incomplete artifact set as expected. The Linux ARM64 and two macOS wheels still need confirmation on their respective build hosts. |
5 participants
Build Python-ABI-independent wheels for supported Linux and macOS targets so users can install LDK Node directly from PyPI.
Keep build and publication available through local scripts. Require the complete artifact set on TestPyPI before production, and exercise the bindings on the oldest and newest supported CPython versions.