Skip to content

feat(widget): add limit order mode#793

Draft
effie-ms wants to merge 10 commits into
mainfrom
feat/emb-322-limit-order-mode
Draft

feat(widget): add limit order mode#793
effie-ms wants to merge 10 commits into
mainfrom
feat/emb-322-limit-order-mode

Conversation

@effie-ms

@effie-ms effie-ms commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Which Linear task is linked to this PR?

https://linear.app/lifi-linear/issue/EMB-322

Why was it implemented this way?

Implement limit order mode as a dedicated header tab.

Extended API endpoints: lifinance/sdk#410

Visual showcase (Screenshots or Videos)

TODO: attach a screen recording of the limit price card, presets, invert toggle, and expiry/partial-fill settings.

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.
  • If this PR modifies the Widget API or adds new features that require documentation, I have updated the documentation in the public-docs repository.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f6d9e68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@lifi/widget Minor
nft-checkout Patch
tanstack-router-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effie-ms effie-ms marked this pull request as draft June 16, 2026 10:53
@effie-ms effie-ms self-assigned this Jun 16, 2026
@effie-ms effie-ms force-pushed the feat/advanced-mode-settings branch 2 times, most recently from 6f66b1a to 14cf8cf Compare June 22, 2026 15:28
@effie-ms effie-ms force-pushed the feat/emb-322-limit-order-mode branch from 58c0a26 to 4b18107 Compare June 24, 2026 10:37
@effie-ms effie-ms changed the base branch from feat/advanced-mode-settings to main June 24, 2026 10:37
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

E2E Examples — all passed

All examples passed in the latest run.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

❌ E2E Dev Smoke — failed

Check Result
Dev server start (pnpm dev) ✅ started
Smoke tests ❌ failed

1 passed · 3 failed · 0 skipped · 52s

  • clicking the Settings icon opens the Settings view
  • token route setup — From and To tokens selected via UI
  • widget container is displayed with Exchange heading

View run — the full HTML report is attached as the playwright-report-dev-smoke artifact.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

E2E Playground results

failed  24 failed
passed  134 passed

Details

stats  158 tests across 10 suites
duration  4 minutes, 5 seconds
commit  f6d9e68

Failed tests

preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (default state) › widget is clean and all toggles are off when entering developer controls
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Form values) › toggling on prefills the widget with the default route
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Form values) › amount preset button sets the send-amount input
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Bookmark stores) › Send to wallet page shows 50 bookmarked wallets after seeding
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Bookmark stores) › navigating into Bookmarked wallets shows the seeded wallet list
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Bookmark stores) › clearing bookmark stores reloads and removes bookmarks from the list
preview › playground/settings.developer-controls.spec.ts › Playground settings — Developer controls (Loading preview) › restores the live widget when toggled off
preview › playground/settings.mode-variant.spec.ts › Playground settings — Mode × Variant: Swap or Bridge + Compact › Swap or Bridge tab strip renders correctly in Compact layout
preview › playground/settings.mode-variant.spec.ts › Playground settings — Mode × Variant: Refuel + Compact › Refuel mode UI is correct in Compact layout
preview › playground/settings.mode-variant.spec.ts › Playground settings — Mode × Variant: Bridge + Drawer › Bridge mode UI is correct inside the Drawer
preview › playground/settings.mode.spec.ts › Playground settings — Mode › Exchange mode is selected by default
preview › playground/settings.mode.spec.ts › Playground settings — Mode › selects Swap or Bridge mode
preview › playground/settings.mode.spec.ts › Playground settings — Mode › selects Swap mode
preview › playground/settings.mode.spec.ts › Playground settings — Mode › selects Bridge mode
preview › playground/settings.mode.spec.ts › Playground settings — Mode › selects Refuel mode
preview › playground/settings.mode.spec.ts › Playground settings — Mode › Swap mode shows the Swap tab and no Bridge tab
preview › playground/settings.mode.spec.ts › Playground settings — Mode › Bridge mode shows the Bridge tab and no Swap tab
preview › playground/settings.mode.spec.ts › Playground settings — Mode › resets mode to default
preview › playground/settings.persistence.spec.ts › Playground settings — Persistence after reload › Mode: Bridge mode survives page reload
preview › playground/settings.theme.spec.ts › Playground settings — Theme › route side panel inherits the active theme
preview › playground/settings.variant.spec.ts › Playground settings — Variant (Wide) › clicking From opens the chain sidebar
preview › playground/settings.variant.spec.ts › Playground settings — Variant (Wide) › clicking To opens the chain sidebar
preview › playground/settings.variant.spec.ts › Playground settings — Variant (Wide) › Reset variant button reverts the nav label and re-enables the chain sidebar
preview › playground/settings.wallet-management.spec.ts › Playground settings — Wallet management (External) › navigation header shows a Close button in External mode (Drawer variant, no Force internal)

📥 Download full HTML report (open the run → Artifacts → playwright-report)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant