Repository navigation
fix(gui): fold Advisor into the Subagents row and collapse its notices - #7196
Conversation
Advisor no longer takes a sidebar row. It joins Subagents as a section-switcher member, the same pattern Usage & Logs uses, and keeps its #advisor route. The three cost and data-sharing warnings fold into one collapsed disclosure; the consent checkbox and its required notice stay visible.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 14 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the two primary changes: moving Advisor into the Subagents row and collapsing its notices. These changes match the documented pull request objectives and affe… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 14 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b55497d68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Notice tone="warn">{t("advisor.disclosure")}</Notice> | ||
| {/* Collapsed by default: three stacked warnings buried the settings below them. The | ||
| consent checkbox and its required notice stay visible, so folding them hides no gate. */} | ||
| <details className="advisor-notices" style={{ margin: "0.5rem 0" }}> |
There was a problem hiding this comment.
The new default-collapsed behavior is not covered: advisor-save-feedback.test.tsx renders only AdvisorEditor, while sidebar-rows.test.ts checks only navigation grouping, so adding open or moving these notices outside <details> could silently restore the three-warning wall this patch is intended to remove. Add a focused Advisor render test that verifies the disclosure starts closed, has the localized summary, and contains the three notices.
AGENTS.md reference: AGENTS.md:L456-L460
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration into
|
1 participant
Summary
The Advisor appeared as its own sidebar row in 2.86, next to Subagents. It now lives under the Subagents row as a section-switcher member, the same pattern Usage & Logs uses: the row opens Subagents, and a Subagents / Advisor pill switcher sits above the page. The Advisor page, its
#advisorroute, and its settings behaviour (including the #7114 catalog model selector) are unchanged.The Advisor's three stacked cost, privacy, and disclosure warnings now fold into one collapsed Cost and data-sharing notices disclosure, so the settings are visible without scrolling. The context-sharing consent checkbox and its "not runnable until consent is recorded" notice stay visible, so folding the notices hides no gate.
This supersedes the revert in #7192: the selector stays, and the tab it added is gone.
Verification
cd gui && bun test tests/: 3340 pass, 0 fail.gui/tests/sidebar-rows.test.tsnow pins eight rows,subagents: ["subagents", "advisor"], andgroupForPage("advisor")resolving to the Subagents row.bun run typecheck, GUItsc --noEmit,oxlint,bun run build:gui,bun run privacy:scan,bun run structure:checkall pass.#advisor.bun run testnot run locally: the change is GUI and docs only, and nosrc/file changed; left to CI.Checklist
Summary by CodeRabbit
Navigation
Advisor
Documentation