[Bug][CI]: cold-spawn warm-up coverage accepts an unused import or comment as execution proof #5060

Activity

1. Ingwannu

   added

   bugSomething isn't workingSomething isn't working

   platformOS/service/tray/ACL (Windows-heavy, not Windows-only)OS/service/tray/ACL (Windows-heavy, not Windows-only)

   on Sep 18, 2026
2. lidge-jun

   added a commit that references this issue on Sep 19, 2026

   fix(tests): judge cold-spawn warm-up registration structurally (#5080)

   ...

   d4ca4d9
3. lidge-jun commented on Sep 19, 2026

   

   lidge-jun

   on Sep 19, 2026

   Owner

   More actions

   Fixed on dev by #5080, merged as the commit above.

   The guard no longer asks whether a file's text contains the warm-up module path. It recognises a small set of exact shapes and refuses everything else by line number:

   hook-statement    describe(...)* > beforeAll(async () => { ... await W(...); ... })
   hook-return       describe(...)* > beforeAll(() => { return W(...); })
   hook-expression   describe(...)* > beforeAll(() => W(...)) and its awaited form
   module-top-level  await W(...); as a whole statement at the top level
   

   W has to come from a direct named import of the helper, aliases followed, and describe and beforeAll have to be direct named imports of bun:test that are not rebound anywhere in the file. A hook inside describe.skip or a conditional describe is a registration in shape only and is refused, because that suite never runs.

   The first draft went the other way and tried to model the grammar generally. Review found it accepted register(() => beforeAll(async () => { await W(options); })), where the hook is never registered, and accepted a locally shadowed const beforeAll = () => {}. Both are false passes, which is the exact failure this guard exists to remove, so the accept-set was narrowed instead. TypeScript 7.0.2 publishes no in-process parser, so the alternative was reconstructing scoping from tokens where every wrong guess is a false pass.

   Shapes that do warm at run time are refused too — a namespace import, a barrel re-export, an alias through a variable, a call in a scope the judge does not model. That is deliberate rather than a backlog: a refusal is loud, located, and a legitimate file needing one records it in its disposition, which keeps the refusal itself under test.

   What this does not claim: a structural check does not prove execution. The helper still prints one completion line per warmed graph on every hosted run, and that remains the separate execution oracle.

   CI at the exact head 151e52ac3c was green on every leg. No local suite was run.
4. lidge-jun

   closed this as completedon Sep 19, 2026