Skip to content

[Bug][CI]: merged regression tests are absent from the authoritative test-layout inventories #5059

Closed

Description

@Ingwannu

Client or integration

CI/test layout only.

Area

Test discovery and maintained inventory.

Summary

Three recently merged regression files are tracked only by broad regex seeds and are absent from both authoritative layout inventories:

Neither scripts/test-layout/layout.json nor tests/fixtures/test-layout-expected.json contains these paths on current dev.

Impact

The tests may run today because their names happen to match broad domain regexes, but the maintained inventory and its expected fixture are incomplete. A future rename or regex change can silently move/drop them without the explicit mapping detecting the ownership change.

Expected behaviour

Register all three files in both inventories with their intended domains, regenerate/verify the fixture through the repository tooling, and add a regression that a newly tracked test cannot rely only on a broad regex when repository policy requires an explicit entry.

Scope

This is inventory correctness, not a request to rewrite the tests or reopen the runtime fixes they cover.

Activity

  1. added
    bugSomething isn't working
    platformOS/service/tray/ACL (Windows-heavy, not Windows-only)
    on Sep 18, 2026
  2. lidge-jun commented on Sep 18, 2026

    @lidge-jun
    Owner

    Fixed on dev by #5075, merged as 3d5efc7255.

    All three files are now registered in both inventories with the same basename-to-domain mapping, which the membership oracle compares directly:

    File Domain Subject
    tests/ci-workflows/ci-structure-gate.test.ts ci-workflows #5050
    tests/responses/responses-code-mode-patch-compile.test.ts responses #5051
    tests/gui/gui-codex-usage-score-parity.test.ts gui #5055

    layout.explicit and tests/fixtures/test-layout-expected.json both went from 1364 to 1367 entries and parse to identical maps. A test in tests/test-layout-tooling.test.ts now names the three so they cannot fall out again silently, and checks that each one actually sits in the directory its registration claims — a registration pointing at a path the tree does not have would otherwise pass.

    The repository-wide question your report raised is deliberately left open: nothing here requires every test to be explicitly classified, so the regex seeds keep carrying brand-new files as designed. Changing that would move 1364 entries under a different policy and is a separate decision.

    CI at the exact head 7529de9512 was green on every leg. No local suite was run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingplatformOS/service/tray/ACL (Windows-heavy, not Windows-only)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions