Repository navigation
Refresh image dimensions after quarter-turn rotations - #194
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 29 29
Lines 7589 7590 +1
=======================================
+ Hits 6533 6534 +1
Misses 1056 1056 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HexDecimal
approved these changes
Oct 12, 2026
HexDecimal
left a comment
Collaborator
There was a problem hiding this comment.
I never gave the libtcod image port the scrutiny it deserved. It was a mistake for me to port it like this, and naturally I only tested rotation on a square image.
Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image.rotate90()updates native pixels but leaves the Python width and height unchanged. For a rectangular image,np.asarray(image)consequently returns the rotated pixels with the old shape.Refresh the dimensions from the native image after rotating. Regressions cover rectangular and square images, signed/full turn counts, and repeated quarter turns.
A photograph-based array-to-semigraphics workflow matches NumPy rotation and a separately rendered reference console after the fix. Before, 20 of 54 configurations produced incorrect images and 30,720 differing console tiles; all 34 unaffected configurations remain identical.
Validation: 11 regressions fail before and all 28 pass after. The full native
--no-windowsuite passes 309 tests with 95 rendering skips; applicable hooks and two-file Mypy pass. Tested on Linux/Python 3.12.