Conversation
Memory corruption issues were discovered when running drive related tests together parallelly (with `cargo test -- --include-ignored`). It was found that the GNU/Linux initialization routine `open_am_linux()` was NOT thread safe. `Drive::devices()` invokes `cdio_get_devices()`, which internally initialized an instance of `CdIo_t`, making this whole chain unsafe. Earlier only `CdIo_t`'s C constructor `cdio_open()` and cleanup function `cdio_destroy()` were deemed thread unsafe, due to their use of a static, and a `Mutex` was used to uphold safety. Given that even the underlying intialization routine is also unsafe, reuse the lock for all routines that in any way initialize `CdIo_t`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory corruption issues were discovered when running drive related
tests together parallelly (with
cargo test -- --include-ignored).It was found that the GNU/Linux initialization routine
open_am_linux()was NOT thread safe.Drive::devices()invokescdio_get_devices(), which internallyinitialized an instance of
CdIo_t, making this whole chain unsafe.Earlier only
CdIo_t's C constructorcdio_open()and cleanupfunction
cdio_destroy()were deemed thread unsafe, due to their useof a static, and a
Mutexwas used to uphold safety.Given that even the underlying intialization routine is also unsafe,
reuse the lock for all routines that in any way initialize
CdIo_t.