proofs: assign helper bridge catalog - #2218
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
| \n### CI Failure Hints\n\nFailed jobs: `build-audits`, `foundry`\n\nCopy-paste local triage:\n```bash\nmake check\nlake build\nFOUNDRY_PROFILE=difftest forge test -vv\n``` |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
🟢 No findings from the OCR first pass. Advisory only.
No comments generated. Looks good to me.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: medium-lean (router-v10)
- Changed files: 2 supported / 2 total; Lean 2, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 15 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status success; comments 0; files 2; tokens 51002; tool calls 10; warnings 0; duration 149s
- Largest changed files: Compiler/Proofs/IRGeneration/GenericInduction/Calls.lean (+12/-0), PrintAxioms.lean (+2/-1)
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the narrow second-interface catalog increment toward #2080.
Verification
python3 scripts/generate_print_axioms.py --checkgit diff --checkLEAN_NUM_THREADS=2 lake build Compiler.Proofs.IRGeneration.GenericInduction.Calls Compiler.Proofs.HelperStepProofsold-agentadcc5d43-6373-4e52-a72b-41d463cc4162097ea15713c23a8ed4aef3d65f6fe20852cd1cdc5exact_headLEAN_NUM_THREADS=2 lake buildashur62513330-efc7-4327-a125-e9f4c19a3ae3097ea15713c23a8ed4aef3d65f6fe20852cd1cdc5exact_headLEAN_NUM_THREADS=2 lake build PrintAxiomsold-agent1cdd0437-23ce-4383-9e5d-316754965f87097ea15713c23a8ed4aef3d65f6fe20852cd1cdc5exact_headThe known
compiler-regressionsOOM on currentmainis tracked in #2214 and is not a gate for this proof-only slice.Note
Low Risk
Proof-only catalog plumbing with no runtime, auth, or compiler behavior changes.
Overview
Adds
directInternalHelperPerCalleeAssignBridgeCatalog_of_bridgeCatalog, mirroring the existing call-only projection: from a fullDirectInternalHelperPerCalleeBridgeCatalog, it yields the assign-only catalog by takinghbridge.assign, so assign-only list-interface assembly can reuse a full catalog without a void-call bridge obligation at the API boundary.Registers the new lemma in
PrintAxioms.lean(6026 public theorems).Reviewed by Cursor Bugbot for commit 97ea157. Bugbot is set up for automated code reviews on this repo. Configure here.