Repository navigation
Serve the container IPC bridge on every host - #134
Merged
Merged
Conversation
The bridge is a std TCP listener driven by async-io and speaks the TCP IPC message format; nothing in it depends on unix, yet it was compiled only under cfg(unix) with a stub that always failed elsewhere, so a container session on a Windows host could run no IPC command. The gates and the stub are gone, and a host-side round-trip test runs on every platform. Closes #133
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 15, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_container_ipc_bridgeand its connection loop were compiled only undercfg(unix), with a stub that always returnedcontainer IPC bridge is only supported on unix hosts. The bridge is astd::netTCP listener driven byasync-iospeaking the TCP IPC message format — no unix sockets or fd passing — so the gates and the stub are removed and one implementation serves every host.New test
container_ipc_bridge_round_trips_a_command_over_tcp(no cfg gate) starts the bridge on loopback, sends one IPC command over TCP and checks the exact response; the windows-latest portability job runs it. macOS: fmt, clippy-D warnings,aither-sandbox165 tests pass.Closes #133