Repository navigation
Release 3.6.0 - #113
Merged
Merged
Release 3.6.0#113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linter reads all the Ruby of a template and
.super-slim.ymlis checked when it is read:super-slim lintmayreport lines it passed before, and a configuration with a misspelt name or a wrong value now stops with an error.
New
.super-slim.ymlmisspells stopslintandformatwith a usage error thatnames it and lists the known ones, instead of being ignored:
LineLenght:left the limit at 120, and a rule carriedover from slim-lint, such as
RuboCop:, did nothing. Rename or remove the entry..super-slim.ymlis reported with the setting it belongs to.max: "120",classes: [close],enabled: "false",tailwind_classes: maybe,max_line_length: 0andattribute_delimiters: "<>"failed onevery template, ended in a backtrace or were taken at their word.
Fixed
InstanceVariablesreads interpolated text, quoted attributes, inline HTML andruby:blocks, not only-and=lines and code attributes, and reports each variable on its own line when code spreads over several. An
@in astring, as in
"npm/@scope/package", is no longer taken for one.UnusedLocalsno longer reports a local read in inline HTML, in an interpolation holding braces such as#{tags.map { |tag| tag.name }}, in an attribute ofjavascript:orcss:, or throughbinding.local_variable_get.UnescapedOutputreportshref=="#{url}",#{{}}in a quoted attribute or in inline HTML, andhtml_safeorrawinside an interpolation.DatabaseQueriesandUnnecessaryInterpolationread interpolations holding braces,and
HardcodedTextno longer takes their code for text./!) at the top of a template is reported on its line, not without one.max_line_length,super-slim formatwrites a template thatformat --checkaccepts. A second run couldrewrite a hash the first had spread, a call with two spaces before its first argument, the children of an output
moved onto its tag, or a
-line joined beside aruby:block. A template the wrapper changes takes about 30%longer to format; one already formatted takes the same time.
max_line_length, a- rescueor- ensureline longer than the limit no longer makessuper-slim formatrefuse the template with a
NoMethodError.*{tag: "section"} Hello, no longer compiles to Ruby that warns underruby -w.Once merged,
bin/releasetags the merge commit v3.6.0, which publishes the gem.