Repository navigation
A name .super-slim.yml misspells is an error, not ignored - #112
Merged
Merged
Conversation
A rule, an option or a setting the linter does not know was skipped in silence: the limit it meant to raise stayed, the rule it meant to turn off stayed on. Unknown names stop lint and format with a usage error that lists the known ones. Assisted-by: Claude Fable 5 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A name
.super-slim.ymlmisspells is ignored.LineLenght: {max: 150}leaves the limit at 120,Instancevariables: {enabled: false}leaves the rule on,formatter: {max_line_length: 120}wraps nothing, andsuper-slim lintexits 0 without a word: the file reads as if it were applied. The linter already reports a rule name it doesn't know in asuper-slim:disablecomment.Unknown names now stop
lintandformatwith a usage error that names them and lists what the file can hold there. This turns a configuration that was read without complaint into an error, which is why this pull request does not merge itself: it wants a decision, and a line under Breaking in the changelog if it goes in.linters:that is no rule ofsuper-slim lint, in the words of the directive's offense.includeandexclude;presetonly on the rules that have one.linters,format,fmtandtailwind_classes, and underformat:anything butmax_line_lengthandattribute_delimiters.RuboCop:orTag:, would fail until the entry is removed.Proof
Each
.super-slim.ymlbelow passessuper-slim lintonmainwith no output and status 0, but the one withpreset, whichmainanswers withLineLength: unknown preset `bootstrap5`, use one of:and an empty list. With this change, status 64 and:.super-slim.ymllinters: {LineLenght: {max: 150}}.super-slim.yml: `LineLenght` is not a rule of super-slim lintlinters: {LineLength: {maximum: 150}}.super-slim.yml: `maximum` is not an option of LineLength, use one of: enabled, max, include, excludelinters: {LineLength: {preset: bootstrap5}}.super-slim.yml: `preset` is not an option of LineLength, use one of: enabled, max, include, excludeformatter: {max_line_length: 120}.super-slim.yml: `formatter` is not a setting, use one of: linters, format, fmt, tailwind_classesformat: {line_length: 120}.super-slim.yml: `line_length` is not a setting of `format`, use one of: max_line_length, attribute_delimiterstest/cli_test.rbholds the five; the README's paragraph on the configuration file says so.