Repository navigation
Conversation
- 3D buildings now show walls that suit their type, such as window rows lit at night, open parking-garage decks and hangar doors, and vary in colour A Cesium 3D Tiles style classifies each OSM building (parking garage, hangar, house, office, terminal, plain) and packs class, storeys, a wall height code and a per-building hash into the style colour, near white; the facade shader decodes it and draws each class's grammar with a hashed palette. Heights come from tagged height less min_height and a tagged roof, else from the estimated height for whole buildings; a part with no height of its own uses the default storey. Hangar door seams are box-filtered over the pixel footprint. The review captures under docs/plans/canvases/osm-facades/ are retaken on Cesium 1.146. Refs: TC3D-164, TC3D-163 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Below the horizon Cesium stops drawing the sun shadow map but receivers keep sampling the last daytime texture, so every wall (lit windows included) lost about 30% of its brightness at night, and a stale sunset shadow patch showed after a noon-to-night switch. useCesiumLighting now enables sun shadows only while the sun is up, and re-runs only when the sun crosses the horizon. useSunElevation computes the sun from Cesium's own clock against the geodetic normal, the same sun and horizon the shadow map uses, so a time switch updates at once. Refs: TC3D-225 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type-aware facades for Cesium's OSM buildings. A 3D Tiles style classifies each building from its OSM tags (parking garage, hangar, house, office, terminal, plain) and packs class, storeys, a wall height code and a per-building hash into the style colour; the facade custom shader decodes it and draws each class's wall grammar with a hashed palette.
Review captures (KSFO garage and tower, KOAK hangar and tower, noon and 22:00):
docs/plans/canvases/osm-facades/. The palette is the owner's call before this merges.Items:
Refs TC3D-226