Repository navigation
Conversation
Ports the weather spike's post-process stage into production: a cloud raymarch and fog composite that read the scene depth, driven by the weather store and settings, anchored on the airport or the followed aircraft, kept after the silhouette stage. The Babylon fog dome and cloud meshes stay behind a non-persisted switch and draw when the view has no logarithmic depth buffer. Refs: TC3D-144 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Fog Intensity sets how thick the depth-drawn fog looks, and terrain in low visibility is no longer fogged twice The weather composite's fog extinction is the quality preset's value times fogIntensity (floored at 0). While the Cesium stage draws fog, useCesiumWeather holds scene.fog at Cesium's clear-weather values instead of tuning it from METAR visibility; with the Babylon overlay drawing the weather, the tuning is unchanged. The stage hook now runs before useCesiumWeather and hands it its gates. Refs: TC3D-145 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The cab moves out of the Babylon overlay into Cesium (useTowerModel), so it writes depth the cloud and fog stage reads, casts a Cesium shadow and darkens at night on the same curve as the imagery (nightBrightness). One axis convention for aircraft and cab (modelOrientation): manifest rotation now turns the cab clockwise from north, as MODDING.md and the positioning wizard always said; rotation 0 faces as before. Aircraft headings are numerically unchanged. Ground height resolves through resolveGroundHeight and re-samples on terrainProviderChanged, so a cab loaded before World Terrain no longer sits on height 0. The Babylon cab, its sun-direction hook, shadow generator and IBL wiring are deleted. window.__tc3d gains towerModel. Refs: TC3D-146 Refs: TC3D-138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The headless check of the Cesium cab showed KOAK's cab hanging 7.45 m off its shaft at its manifest rotation 0 and centred at 90: tower manifests were tuned against the earlier Cesium cab, whose glTF +X faced east at rotation 0. The cab now keeps that convention, through the shared compass helper with a 90-degree cab offset, and turns clockwise from there. MODDING.md and CLAUDE.md say so. Refs: TC3D-146 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Cesium weather stage draws clouds and fog and the tower cab has left Babylon, so the Babylon dome, cloud planes, their textures and recentring, the Babylon night lighting and the weather renderer switch go. Label weather culling moves into useBabylonOverlay unchanged. With log depth off the stage stays hidden and there is no Babylon fallback (owner ruling). Babylon keeps rain, snow, lightning and datablock labels. Refs: TC3D-149 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone M2 of the Babylon to Cesium migration: tower cab, clouds and fog drawn by Cesium. Merges after the owner's look sign-off and the iPad measurement (TC3D-150). Design:
docs/plans/babylon-to-cesium.md, M2.docs/plans/canvases/cesium-weather-stage/)scene.fogRefs TC3D-221