Repository navigation
fix(settle): a blank capture never stands in for the tree check - #139
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ir the frame fixture - An app that hides its screen from capture (PayPay) yields the same blank frame whether or not it moved, so two identical frames around the read declared a moving screen settled. Blank frames now fall back to comparing trees. - FRAME_B in the settle tests was non-canonical base64: it failed to decode, so 'frames that differ' was really testing 'the second capture failed'. Also tried (not kept): waiting for frames to hold still before the first tree read. On Settings it sped up some steps (6.5 s -> 3 s) and slowed pages that load content after the transition (about 关于本机: 4.6-6.8 s -> 7 s); the mean moved 6.1 s -> 5.9 s, within noise.
leeguooooo
force-pushed
the
perf/settle-frames-first
branch
from
October 6, 2026 10:53
34373f0 to
421b6d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes. One finding that did not pan out is recorded here so nobody repeats it.
redaction::content_band_is_blank) now fall back to comparing trees. Test:blank_frames_never_count_as_settled.FRAME_Bwas non-canonical base64 and failed to decode, soframes_that_differ_fall_back_to_comparing_treeswas really exercising a failed capture.Tried, not kept: wait for frames to hold still before the first tree read.
Hardware: v0.13.1, Settings 通用 → 关于本机 → back → back, observe on, USB.
Per page:
/sourceread.The net change is within noise, so the behaviour is not merged. The bigger lever is the cost of each tree read itself: the wechat-project session found that
isVisibledominates/sourcetime (heavy-tree lite-source work).server + mcp: 598 passed.