Repository navigation
feat(observe): an observed action with no baseline diffs against the owner's last read - #138
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…owner's last read Usage log (2274 requests): 0 of 821 element reads used ?since and 23 of 1010 actions asked for return=delta — plain HTTP agents never carry the snapshot token. The daemon now remembers the last snapshot each named owner (X-Phone-Owner) was handed — an elements read, an observed action, an observed batch — and an observed action that names no baseline diffs against it. Explicit since / snapshot still win; anonymous clients are unchanged.
leeguooooo
force-pushed
the
feat/auto-baseline
branch
from
October 6, 2026 10:47
78a9104 to
0218554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: in the usage log (2274 requests over about two days), 0 of 821 element reads used
?since, and 23 of 1010 actions asked forreturn=delta, most of them our own benchmarks. Plain HTTP agents never carry the snapshot token, so the diff feature went unused.What changes:
X-Phone-Owner) was handed: an elements read, an observed action, or an observed batch.since, nosnapshotin the body) now diffs against that snapshot.sinceorsnapshotstill wins. Anonymous clients are unchanged.Hardware measurement on v0.13.1, Settings: 通用 → 关于本机 → back → back, 2 rounds per mode.
/agent/elementsreturn=delta)What the numbers say:
/sourceis 1.3–1.7 s for ~400 KB) whenever the frames around the first read differ mid-animation. A follow-up will settle on frames first and read the tree once.Tests:
an_observed_action_diffs_against_the_owners_last_read. server + mcp: 597 passed.