Repository navigation
feat(tap_locator): via:point for custom controls that ignore element clicks - #137
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…clicks Hardware (Xiaohongshu 9.49.1): the 30x30 back button acknowledged two XCUIElement clicks and stayed put; a W3C coordinate tap at its centre opened its menu. tap_locator gains 'via':'point': the locator is still proven unique, then the centre of the element's LIVE frame (WDA element rect, not the /source rect that misses in system sheets) is tapped once. Default stays element click. MCP/flow tap_locator steps carry via.
leeguooooo
force-pushed
the
feat/tap-via-point
branch
from
October 6, 2026 10:26
83d1e8a to
7a7803f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: On Xiaohongshu 9.49.1 the 30×30 back button (label 返回, no identifier) acknowledged two XCUIElement clicks from
tap_locatorand the page stayed put. A coordinate tap at its centre opened the menu. Reported with exact rects by the parallel session.What:
tap_locatorgains"via": "point"./sourcerect, which misses inside system sheets.viareturns 400.tap_locatorsteps carryvia.Not automatic: I chose not to add a coordinate tap after every element click. If the first click did act, a second tap lands on whatever is now under it.
Tests: new daemon integration test: centre (30, 84), no
/click, badvia→ 400.cargo test -p serverand-p iphone-use-mcppass.