Skip to content

fix(site): announce adapters when switching to a tab that is still loading - #406

Merged
leeguooooo merged 2 commits into
mainfrom
fix/site-hint-loading-tab
Oct 6, 2026
Merged

leeguooooo merged 2 commits into
mainfrom
fix/site-hint-loading-tab

Conversation

@leeguooooo

@leeguooooo leeguooooo commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

A tab opened in the background can still read about:blank from page JS when the agent switches to it, so 1.5.159 recorded an empty host and never announced that site's adapters. The hint now uses the url the command reported (a tab switch takes it from Chrome's tab info) before asking the page, and an empty host is left unknown so the next command checks again.

Verified with a release build in real Chrome: open example.com → tab new https://news.ycombinator.com → tab t1 → tab t2 now prints the hackernews adapters (1.5.159 printed nothing).

Summary by CodeRabbit

  • Bug Fixes
    • Site detection now uses a valid URL returned by a command when available, improving the accuracy of the displayed site context.
    • Pages without a recognizable host remain marked as unknown, allowing subsequent commands to check again.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 144a660b-1d60-4dc3-94da-cdce46d2ac5d
📥 Commits

Reviewing files that changed from the base of the PR and between 44a6032 and ec37c6f.

📒 Files selected for processing (1)
  • cli/src/native/actions.rs
 _______________________________________________
< Finding more bugs than your brain at 4:00 pm. >
 -----------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@leeguooooo
leeguooooo merged commit b3df17d into main Oct 6, 2026
8 of 9 checks passed
@leeguooooo
leeguooooo deleted the fix/site-hint-loading-tab branch October 6, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant