[fork-CI] [19.0][MIG] web_toggle_chatter: Migration to 19.0#8
Draft
dnplkndll wants to merge 5 commits into
Draft
[fork-CI] [19.0][MIG] web_toggle_chatter: Migration to 19.0#8dnplkndll wants to merge 5 commits into
dnplkndll wants to merge 5 commits into
Conversation
dnplkndll
force-pushed
the
19.0-mig-web_toggle_chatter
branch
3 times, most recently
from
1b676fe to
766320e
Compare
dnplkndll
force-pushed
the
19.0-mig-web_toggle_chatter
branch
4 times, most recently
from
817d3ca to
1c77cbe
Compare
The module shipped a JS unit test but no HttpCase runner, so it never ran in CI. Add the runner, and adapt the test to the 19.0 form layout: core now renders the form sheet + chatter side by side only at >= XXL (stacking them as `flex-column` below that), and the toggle is intentionally hidden in the stacked layout. The test now forces the wide/sided layout, mocks the chatter the same way mail compiles it, and asserts on the chatter's own state so it is deterministic regardless of test order or runner viewport.
dnplkndll
force-pushed
the
19.0-mig-web_toggle_chatter
branch
from
1c77cbe to
840b661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of web_toggle_chatter from 18.0 to 19.0.
Migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0