[REVIEW] database_size: rebuilt 18.0 history (replay + bot-squash)#15
Closed
dnplkndll wants to merge 10 commits into
Closed
[REVIEW] database_size: rebuilt 18.0 history (replay + bot-squash)#15dnplkndll wants to merge 10 commits into
dnplkndll wants to merge 10 commits into
Conversation
Currently translated at 100.0% (68 of 68 strings) Translation: server-tools-18.0/server-tools-18.0-database_size Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_size/it/
Currently translated at 100.0% (68 of 68 strings) Translation: server-tools-18.0/server-tools-18.0-database_size Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_size/it/
Fixes
```
File "/home/odoo/.local/lib/python3.12/site-packages/sentry_sdk/client.py", line 595, in _prepare_event
new_event = before_send(event, hint or {})
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/odoo/src/user/oca-server-tools/sentry/hooks.py", line 66, in before_send
if event.setdefault("tags", {})["include_context"]:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'include_context'
2025-07-08 14:45:45,907 14296 INFO quatra-18-0-development-21441249 sentry_sdk.errors: before send dropped event
```
Error is only logged when running Sentry in debug mode, otherwise events are dropped silently.
Though TransactionCase rolls back database changes, it does not call `unlink` on `auditlog.rule` records, meaning that `unsubscribe` is never called to unpatch model methods. This causes subsequent tests in other modules to unexpectedly execute patched methods. This commit adds the `AuditLogRuleCommon` test class in an attempt to identify and prevent patched methods from contaminating the test environment.
Currently translated at 13.2% (9 of 68 strings) Translation: server-tools-18.0/server-tools-18.0-database_size Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_size/fr/
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
- read_group override → _read_group (19.0 deprecated public read_group + web no longer routes through it). New signature (groupby/aggregates/having/order); still defaults the group order for the report views. - search view: dropped `expand`/`string` from the Group By <group> (19.0 RelaxNG rejects them on search-view groups). - _sql_constraints → models.Constraint (kept uniq_model_measurement_date name). - report: f-strings inside self.env._() → %(name)s placeholders (19.0 pylint translation-fstring-interpolation). - _compute_model_name: justified `# pylint: disable=no-search-all` (small ir.model registry load). Signed-off-by: Don Kendall <dkendall@ledoweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structure-verification copy of the database_size MIG, rebuilt to fix StefanRijnhart's concern on OCA#3632 ("why don't the commits reflect the 18.0 history?").
What was wrong on OCA#3632
[ADD] database_size— original authorship/history lost.i18n/fr.po(Sylvain LE GAL's French translation).This branch (odoo-mig skill)
database_sizehistory viaformat-patch | git am(original authors preserved), then squashed the 4 bot commits into their predecessors (OCA transbot-reduction — folds, never drops; tree verified identical, translations kept).[IMP]+[MIG]on top (the[MIG]diff is byte-identical to [19.0][MIG] database_size: Migration to 19.0 OCA/server-tools#3632 — no substance change).fr.porestored; everything else identical.Ladder:
(The two [FIX] commits touched database_size's generated README/index in 18.0, so they're part of its real path history.)
Copy branch for approval — once confirmed, the same ladder force-pushes to
19.0-mig-database_size(OCA#3632).