Skip to content

Replace hardcoded toolbar breakpoints with KListWithOverflow #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nucleogenesis wants to merge 8 commits into
base: unstable
Choose a base branch
from
Open

Replace hardcoded toolbar breakpoints with KListWithOverflow #5707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80a8442
Replace hardcoded toolbar breakpoints with KListWithOverflow
nucleogenesis Feb 16, 2026
e6918cd
TEMP: pin kolibri-design-system to KDS#1246 fork branch for review
nucleogenesis Apr 29, 2026
29cfa58
Standardize toolbarGroups
AlexVelezLl May 20, 2026
a71450f
Overflow items into KDropdownMenu
AlexVelezLl May 27, 2026
0004010
Add dividers
AlexVelezLl May 27, 2026
5ae22b9
Add skip prop to unsupported groups
AlexVelezLl May 27, 2026
f493566
Follow codebase conventions
AlexVelezLl May 27, 2026
3bddc07
Polish last details
AlexVelezLl Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...curation/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/TipTapEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,12 +183,11 @@
};

onMounted(() => {
// capture
document.addEventListener('click', handleClickOutside, true);
document.addEventListener('click', handleClickOutside);
});

onUnmounted(() => {
document.removeEventListener('click', handleClickOutside, true);
Comment on lines -186 to -191
Copy link
Copy Markdown
Member

@AlexVelezLl AlexVelezLl Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove this last true so that the event listener triggered the handler on the event bubble instead of doing so on the event capture phase; this leaves us space to call .stopPropagation on nodes outside the tiptap editor DOM tree (e.g., KDropdown renders the dropdown in a different dropdown layer). I have tested this extensively and haven't found any unexpected regression.

document.removeEventListener('click', handleClickOutside);
});

const getMarkdownContent = () => {
Expand Down
Loading
Loading