Skip to content

Remove multiprocessing fallback for key generation. Stay in process.#331

Merged
rtibbles merged 1 commit into
learningequality:release-v0.8.xfrom
rtibbles:no_zombies_please_were_british
Jun 4, 2026
Merged

Remove multiprocessing fallback for key generation. Stay in process.#331
rtibbles merged 1 commit into
learningequality:release-v0.8.xfrom
rtibbles:no_zombies_please_were_british

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Jun 4, 2026

Summary

Removes the multiprocessing usage when creating keys using pure Python RSA - when no cryptography library is installed.

Reviewer guidance

I don't think this loses any error handling as we were calling this code in the except clause before anyway.

Issues addressed

No explicit issues, may clean up zombies on no cextension Kolibris though.

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtibbles rtibbles merged commit ccc64ee into learningequality:release-v0.8.x Jun 4, 2026
24 checks passed
@rtibbles rtibbles deleted the no_zombies_please_were_british branch June 4, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants