Repository navigation
refactor: getProjectForViewer - #204
Merged
Merged
Conversation
Merged
robsimmons
force-pushed
the
get-project-for-viewer
branch
from
October 29, 2026 20:12
b091f74 to
e11116e
Compare
robsimmons
force-pushed
the
get-project-for-viewer
branch
from
October 29, 2026 20:22
e11116e to
8d700d5
Compare
jcreedcmu
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we've had three repetitions of the pattern "look up owner, look up project, check if the logged-in user has access to /, and those were all the uses of
canAccessProject(), this captures the repeated protocol (but still expects the caller to get the session, presumably viarequireAuth, and to respond to a failed lookup, presumably vianotFound)