Skip to content

feat: better redirect post-login - #202

Merged
robsimmons merged 3 commits into
mainfrom
redirect-at-login
Oct 29, 2026
Merged

robsimmons merged 3 commits into
mainfrom
redirect-at-login

Conversation

@robsimmons

@robsimmons robsimmons commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator
  • Adds a not-found page (which is mostly unused because of catchall routes, you'd have to go to /api/fnord or something.
  • Within the /[userName] tree, unauthorized goes to a page that says "hey do you want to log in"
  • GitHub social login now returns you to the place you left
  • Logged in users get redirected from / to their profile at the proxy level.

Closes #181. Closes #189. Replaces #131.

Comment thread src/app/[userName]/unauthorized.tsx Resolved
Comment thread src/app/not-found.tsx Resolved

@jcreedcmu jcreedcmu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd lean a little bit more into neutral-tone copy. My reasoning is we can imagine deployments across a variety of different social situations (university course, informal workshop, group of math pals) where the level of (in)formality isn't clear.

Otherwise, this is great, successful login returning to where you left off is something I made a mental note earlier about wanting and forgot to file an issue and I'm happy to see it implemented.

robsimmons and others added 2 commits October 29, 2026 10:59
Co-authored-by: Jason <jcreed@gmail.com>
Co-authored-by: Jason <jcreed@gmail.com>
@robsimmons
robsimmons merged commit dcb1158 into main Oct 29, 2026
1 check passed
@robsimmons
robsimmons deleted the redirect-at-login branch October 29, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collaboration experience is initially bad Consider replacing landing page with user profile

2 participants