Repository navigation
feat: set MATHLIB_CACHE_GET_URL to cache.mathlib.org for Mathlib cache downloads - #202
Open
marcelolynch wants to merge 3 commits into
Open
marcelolynch wants to merge 3 commits into
marcelolynch wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
MATHLIB_CACHE_GET_URLtohttps://cache.mathlib.org/mathlib4in the step that runslake exe cache get. Mathlib cache clients that read this variable then download from cache.mathlib.org.The effect depends on the Mathlib version:
The action handles the variable as follows:
The action unsets an empty value because the cache client reads an empty value as a URL. A test on a GitHub-hosted runner confirms that an empty value in a step-level or job-level
envreaches the step as an empty variable.The variable applies only to the
lake exe cache getstep. The README and the CHANGELOG describe the change.🤖