Repository navigation
fix: cache test and lint build artifacts - #197
Merged
austinletson merged 1 commit intoOct 12, 2026
Merged
Conversation
SamuelSchlesinger
marked this pull request as ready for review
October 1, 2026 17:46
Collaborator
|
LGTM. @austinletson? |
This PR saves the GitHub cache after testing and linting so their build artifacts can be reused, while preserving separate build, test, and lint reporting. It retains caching after test or lint failures and skips saves on exact cache hits. Based on [Chris's suggestion](leanprover/cslib#1015 (comment)). Codex assisted with implementation and validation.
SamuelSchlesinger
force-pushed
the
samschles/cache-after-checks
branch
from
October 2, 2026 13:42
20b96a1 to
dd82de1
Compare
Contributor
Author
|
I'd love to have this merge so I can stop doing hacks to avoid this problem. |
Collaborator
|
Looks good. Merged. |
Collaborator
|
@SamuelSchlesinger I am cutting a bug fix release now, so you should be able to use this shortly. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR saves the GitHub cache after testing and linting so their build artifacts can be reused, while preserving separate build, test, and lint reporting. It retains caching after test or lint failures and skips saves on exact cache hits.
Based on Chris's suggestion.
Codex assisted with implementation and validation.