feat(Analysis/LocallyConvex): characterize dense submodules by annihilators - #43747
Open
yuanyi-350 wants to merge 3 commits into
Open
yuanyi-350 wants to merge 3 commits into
yuanyi-350 wants to merge 3 commits into
Conversation
PR summary 1c7a40bf34Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.LocallyConvex.Polar | 1642 | 2251 | +609 (+37.09%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.LocallyConvex.Polar |
609 |
Declarations diff (regex)
+ dense_iff_forall_dual_eq_zero
+ dense_iff_polarSubmodule_eq_bot
+ exists_dual_annihilator_of_not_dense
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
1c7a40b).
- +4 new declarations
- −0 removed declarations
+StrongDual.polarSubmodule.congr_simp
+Submodule.dense_iff_forall_dual_eq_zero
+Submodule.dense_iff_polarSubmodule_eq_bot
+Submodule.exists_dual_annihilator_of_not_denseNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 1c7a40bf34
Reference commit a79b0d211a
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 of 4 tasks
JovanGerb
removed their request for review
September 13, 2026 14:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used in LeanMachineLearning/LML#246