Skip to content

fix: brace installer log variables #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcEverflow merged 1 commit into from
Aug 13, 2026
Merged

fix: brace installer log variables #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/install-launch-agent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,5 +141,5 @@ agentbar_remove_obsolete_log_file /tmp/agentbar.launchd.log
agentbar_remove_obsolete_log_file /tmp/agentbar.launchd.err.log

echo "已从源码目录安装并启动: $PLIST"
echo "日志: $STDOUT_LOG / $STDERR_LOG（权限 0600）"
echo "日志: ${STDOUT_LOG} / ${STDERR_LOG}（权限 0600）"
echo "提示: 移动或删除源码目录后 LaunchAgent 将无法启动；独立安装请使用 DMG。"
9 changes: 9 additions & 0 deletions tests/test_release_scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ def test_installer_is_atomic_and_has_failure_rollback():
assert "cat > \"$PLIST\"" not in installer


def test_installer_braces_variables_before_unicode_punctuation():
installer = (SCRIPTS / "install-launch-agent.sh").read_text(encoding="utf-8")

# In a UTF-8 locale Bash can treat full-width punctuation adjacent to an
# unbraced expansion as part of the variable name under `set -u`.
assert "${STDERR_LOG}（权限 0600）" in installer
assert "$STDERR_LOG（" not in installer


def test_dmg_build_uses_locked_dependencies_and_cleans_temporary_outputs():
build = (SCRIPTS / "build-dmg.sh").read_text(encoding="utf-8")
assert "uv.lock" in build
Expand Down
Loading