Repository navigation
Skills: correctness and 8.7.0 consistency pass - #58
Open
ronpandolfi wants to merge 11 commits into
Open
ronpandolfi wants to merge 11 commits into
ronpandolfi wants to merge 11 commits into
Conversation
… tell(append=True), and canonicalize hps/args tables
…ask EI incumbent, and document ask(args=)
…and distance recipes
…clarify Wendland kernel exports
…tesian shape, use method='adam' for deep kernel, and deduplicate hps table
…g cartesian snippet, and qualify EI task-independence
…ion, noise_function_grad, and deduplicate hps table
…sk shapes, and deduplicate hps table
…e=(a,b) rescaling for target probability and pickling, and fix notebook link text
…ion limitation, and deduplicate hps/args/pickling tables
…ct shape assertion, and add n_restarts=1 to in-loop train
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 8 8
Lines 1509 1509
=======================================
Hits 1488 1488
Misses 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit and fix pass over all 11 agent skills against the current source (gpCAM master, fvgp 4.11.1). Each claim about the API was checked against
gpcam/gp_optimizer_base.pyor the fvgp 4.11.1 source before the text was changed. There's one commit per skill.Corrections
experiment-designer: the text saidtell()replaces data by default. The default isappend=True(gp_optimizer_base.py,def tell).prior-mean-functions: the description said the default prior is a "flat zero prior". The body (correctly) says it'smean(y_data).acquisition-functions: reconciled withreferences/choosing-an-acquisition-function.md(they had drifted apart), fixed the multi-task EI incumbent, and documentedask(args=...).gp2scale-advanced:Client()snippets now sit underif __name__ == "__main__":.kernel-designer: the deep-kernel example trains withmethod="adam", which is what its own notes recommend.uncertainty-calibration:posterior_meanreturns a dict, and the in-loop retrain usesn_restarts.Consistency with 8.7.0
experiment-designernow covers the multi-task modes of the singleGPOptimizer. The noise, prior-mean and kernel skills note the cartesian-mode shapes.argsdispatch table are now in one canonical place (experiment-designer). The other skills point to it instead of repeating it, which cuts about 2.5k words (−10%).Interaction with #57: #57 moves
skills/togpcam/skills/. Git's rename detection should merge these edits cleanly in either order. After the move, the relative link../../examples/GPOptimizer_LogAndLogit.ipynbintransformed-optimizers-advancedneeds one more../.🤖 Generated with Claude Code