Repository navigation
Use one visible keyboard focus ring - #206
Merged
Merged
Conversation
tebriz91
force-pushed
the
windows/focus-ring
branch
from
October 28, 2026 03:47
c6d65db to
b0de157
Compare
tebriz91
force-pushed
the
windows/focus-ring
branch
from
October 28, 2026 03:57
b0de157 to
59f4ba4
Compare
tebriz91
marked this pull request as ready for review
October 28, 2026 03:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard focus now adds one 2 px accent ring with a 2 px outside offset, remaining visible while toolbar panels are open (fixes #194).
focus_visiblestyle with the shared ring. Include sidebar and Settings rows, text inputs, Inspector tabs, and the newly merged shortcuts sheet.changes/focus-ring.md.Validation
origin/mainatb7c1d28, including merged feat(ui): keyboard shortcuts panel from one binding table (ADR 0073) #204.just lintandjust testpassed: 822 tests passed, 20 intentionally ignored, plus release-script tests.just fmt-check,just deny, andjust lint-scriptspassed.just headless-renders target/focus-ring-renders-completepassed: 50 screen records and 10 focused/resting comparisons across light and dark. Pixel checks verify the stroke, unchanged fills/labels, and all sides, including Review beside selected Share.Review
Claude Haiku (
claude-haiku-5-5, max) failed withClaude API rate limit reached. Try again later.Used the user-authorized fallback, Codexgpt-6.1-solwith high reasoning effort.The follow-up Codex review confirmed those three fixes and found one further P2:
comments.docxfixture in the actual Original pane; it failed before the fix with one missing side and now passes in both themes. The headless runner waits for DOCX temporary-file cleanup before writing its summary.No other significant findings were reported in the follow-up review. All four findings have been addressed. Final head:
59f4ba42b846f55ae3245f0016b02bb4e404f395.Native Windows verification remains pending: needs the user at the machine.
sky.list_windows()returnedComputer Use native pipe is unavailable: failed to connect native pipe: The system cannot find the file specified. (os error 2). No native app was started or captured. The headless DirectX WARP checks do not establish native keyboard, accessibility, IME or display-presentation acceptance.Do not merge.