Repository navigation
Save as Case on close retries a failed case save - #202
Merged
Merged
Conversation
A tab whose case save failed already has a case link, so create_case returned early and nothing closed the tab. Retry the waiting revision and close the tab once it is written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pt was open Codex review of #202: the case can recover between the prompt and the answer; with nothing waiting, close the tab at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #189 (ROADMAP 0.3.0 item 6).
save_case_and_closecalledcreate_case, which returns early when the tab already has a case link, so a tab whose case save had failed stayed open with no explanation. Now, when the tab's case is marked failed,CaseCoordinator::retry_and_closemarks the tab to close after the save and pumps the waiting (latest) revision. If the retry fails again, the existing failure path releases the close and shows the error.Tests: coordinator unit test, plus a workspace test that blocks the store, repairs it, chooses Save as Case and checks the tab closes and the case is written.
Codex review (gpt-6.1-sol, high)
write_faileddeliberately doesn't restart the queue, since a persistent failure would otherwise loop. The tab stays open with the failure notice, as for any failed save; the next case action restarts the queue. Rare (two cases failing at once).close_afterholds one tab per case, as before this PR. The first tab stays open and can be closed again. Rare; worth a list only if it shows up.save_and_closecloses the tab at once when nothing waits for that case; unit test added.🤖 Generated with Claude Code