Skip to content

chore(deps): update non-burn dependencies and GitHub Actions - #239

Merged
laurigates merged 3 commits into
mainfrom
ccr-356fa78e-wmzug4
Oct 23, 2026
Merged

laurigates merged 3 commits into
mainfrom
ccr-356fa78e-wmzug4

Conversation

@laurigates

@laurigates laurigates commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

What

Updates every dependency on the Renovate dashboard (#16) except the burn family, plus the in-range Cargo.lock refresh.

Cargo (exact pins kept)

  • anyhow 1.0.104, serde 1.0.229, serde_json 1.0.154, tokio 1.53.3
  • futures-core 0.3.34, http-body-util 0.1.5
  • clap 4.6.7, clap_complete 4.6.11
  • sentry 0.46.2 -> 0.49.3, tokenizers 0.22.2 -> 0.23.2, ureq 3.3.0 -> 3.4.2
  • regex 1.13.1, memmap2 0.9.12
  • cargo update for in-range transitives. burn / burn-ndarray / burn-flex / burn-store stay at =0.21.0.

Deliberately held, to avoid duplicate copies in the tree

  • safetensors stays =0.7.0: burn-store 0.21 depends on exactly 0.7.0, and 0.8 is a new minor of a 0.x crate, so bumping would add a second copy beside burn-store's. Move it with the burn bump (Prepare the burn 0.22 migration: backend-erased tensors — API-delta map, staged plan, re-validation gates #79).
  • sha2 stays =0.10.9: the rest of the tree (pbkdf2, tracel-llvm-bundler) is on 0.10, so 0.11 would add a duplicate. The old comment said sha2 was transitive via burn-store; it is not, so the comment is corrected.
  • regex and memmap2 are semver-compatible ranges burn-store accepts, so they unify and were bumped.
  • Not avoidable: tokenizers 0.22.2 stays in Cargo.lock because burn's opt-in candle backend (candle-core) pins it; it only compiles with --features candle. The default tree has the single 0.23.2.

Code change: sentry 0.49 made ClientOptions #[non_exhaustive], so init_telemetry (crates/loractl-cli/src/cli.rs) now assigns release on a default instead of a struct literal. tokenizers 0.23 and ureq 3.4 needed no code changes.

Behaviour changes to know about

  • sentry 0.49 pulls reqwest 0.13, whose rustls transport uses aws-lc-rs (a C build; aws-lc-sys is new in the tree) and verifies against the OS trust store instead of embedded webpki roots. An https:// DSN needs CA certificates on the host; an http:// DSN (the README example) is unaffected. The default ClientOptions otherwise differ only by new fields for features that are not enabled.
  • tokenizers 0.23 replaces the added-token matcher (aho-corasick -> daachorse). Checked by encoding the Qwen3 chat-template prefix/suffix and 23 adversarial captions (adjacent special tokens, unicode, CRLF) with a real Qwen3-VL tokenizer.json under both versions: ids and offsets were identical.

GitHub Actions

  • actions/checkout v7.0.1 everywhere (gpu.yml was on v4.4.0), actions/upload-artifact v7.0.2, Swatinem/rust-cache v2.9.3, actions/create-github-app-token v3.3.0
  • googleapis/release-please-action v5.0.0: the only breaking change is the node24 runtime upgrade; the outputs release-please.yml reads (prs_created, pr) are still set, so it needs no edits beyond the version.
  • checkout / upload-artifact / release-please / app-token all run on Node 24. The self-hosted GPU runner therefore needs Actions runner >= 2.327.1; this is now recorded in the gpu.yml header.
  • create-github-app-token marks app-id deprecated in favour of client-id, but it still works; vars.RELEASE_PLEASE_APP_ID holds an App ID, so the input was left alone (a deprecation annotation will appear).
  • Connorrmcd6/surface v0.9.0 (still SHA-pinned, df2ba902... is the v0.9.0 tag, version: v0.9.0). 0.8.x -> 0.9.0 changes only the action's default install version; we pass version: explicitly, so behaviour is the same. No hubs/ anchor touches the changed code (cli.rs is not anchored).

Why

Clears the non-burn part of the Dependency Dashboard (#16). After this merges, Renovate's #235 shrinks to the burn-only delta (burn 0.22 is the backend-erased redesign tracked in #79 and drops the candle feature, so it is out of scope here).

Verification

  • cargo fmt --all -- --check && cargo clippy --all-targets -- -D warnings clean; full cargo test --no-fail-fast passes (exit 0); cargo test --examples passes
  • Touched a feature-gated path? Ran cargo clippy -p loractl-core --all-targets --features <f> -- -D warnings for mnist, gpt2-real, qwen-vae-real, qwen3vl-real, mmdit-real, wgpu: all clean
  • Touched dependencies? cargo deny check licenses bans sources (CI's gate) passes; cargo audit passes with the .cargo/audit.toml ignores. RUSTSEC-2026-0367/0368/0369 hit zip 0.6.6 (via tch / torch-sys) and 7.4.0 (via candle-core), both only through burn's opt-in tch / candle backends (fixed only in zip >= 9). All three concern ZipArchive::extract() / ZipStreamReader::extract(); no dependent calls them (candle-core and tch use by_name / by_index, torch-sys's build script copies entries by hand). They were present before this change (zip 0.6.6 and 7.2.0 on main), so this PR neither introduces nor fixes them.
  • Hosted CI exercised: ci.yml (checkout v7, rust-cache), docs-drift.yml (surface v0.9.0), security-audit.yml
  • Not exercised by PR CI (push-to-main / dispatch only): release-please.yml (release-please v5, app-token 3.3.0, checkout v7 on the release branch) and gpu.yml (self-hosted runner). Their action inputs/outputs were checked against each action's action.yml / bundled source at the pinned tag; a gh workflow run gpu.yml dispatch and the first post-merge release-please run are the real checks.
  • New ML code is verified against a reference: n/a, no ML code changed
  • Workflow YAML: parsed with Python yaml only; actionlint was not available locally

Linked issue

Refs #16
Refs #79


Generated by Claude Code

Cargo: anyhow 1.0.104, serde 1.0.229, serde_json 1.0.154, tokio 1.53.3,
futures-core 0.3.34, http-body-util 0.1.5, clap 4.6.7, clap_complete 4.6.11,
sentry 0.46.2 -> 0.49.3, regex 1.13.1, tokenizers 0.22.2 -> 0.23.2,
memmap2 0.9.12, ureq 3.3.0 -> 3.4.2; Cargo.lock refreshed in range. The burn
family stays at =0.21.0 (0.22 is the backend-erased redesign, #79).

safetensors (0.7.0) and sha2 (0.10.9) are deliberately held: bumping either
would add a second copy next to the one burn's tree pulls.

sentry 0.49 made ClientOptions #[non_exhaustive], so init_telemetry assigns
`release` on a default instead of using a struct literal.

Actions: actions/checkout v7.0.1 (gpu.yml was on v4.4.0), upload-artifact
v7.0.2, Swatinem/rust-cache v2.9.3, create-github-app-token v3.3.0,
release-please-action v5.0.0 (node24 only; inputs/outputs unchanged),
Connorrmcd6/surface v0.9.0 (SHA-pinned; explicit version input kept).

Refs #16, Refs #79

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
RUSTSEC-2026-0367/0368/0369 (published 2026-10-09/10) hit zip 0.6.6 and
7.x, which reach the lockfile only via burn 0.21's opt-in tch and candle
backends. The fix (zip >= 9) is unreachable without the burn 0.22
migration (#79). All three are in ZipArchive/ZipStreamReader::extract(),
which no dependent calls: candle-core and tch read entries via by_name,
and torch-sys's build script copies entries by hand via by_index +
mangled_name. The advisories also fail main's lockfile, so this is not
caused by the dependency bump; it lands here because this PR is the
first to re-run the audit job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
audit.toml: candle-core/tch read zip entries via by_name and by_index (not
by_name only); the conclusion is unchanged - no dependent calls the extract()
APIs the three advisories concern.

Cargo.toml: note the duplicate tokenizers 0.22.2 kept by candle-core, and
that sentry 0.49 now uses aws-lc-rs plus the OS trust store.

gpu.yml: record the Node 24 runner prerequisite introduced by checkout and
upload-artifact v7 (the file is dispatch-only, so PR CI cannot exercise it).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
@laurigates
laurigates marked this pull request as ready for review October 23, 2026 04:30
@laurigates
laurigates merged commit c52f517 into main Oct 23, 2026
5 checks passed
@laurigates
laurigates deleted the ccr-356fa78e-wmzug4 branch October 23, 2026 04:30
laurigates pushed a commit that referenced this pull request Oct 23, 2026
Brings in the dependency update (#239), including the zip advisory
ignores that clear this branch's audit job. Cargo.lock taken from main
and re-resolved for the plot feature's plotters/ab_glyph subtree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
laurigates pushed a commit that referenced this pull request Oct 23, 2026
Brings in the dependency update (#239, ureq 3.4). hf.rs builds and its
auth/redirect tests pass against ureq 3.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
laurigates pushed a commit that referenced this pull request Oct 23, 2026
Brings in #239 (deps), #240 (HF auth) and #241 (plot feature). The only
conflict was docs/roadmap.md, where #212 and #215 each appended a
section; both are kept, and #215's note that the LR panel stays flat
"until #212" now describes the schedule it plots.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
laurigates pushed a commit that referenced this pull request Oct 23, 2026
Brings in #239-#242. No conflicts; decode_probe builds and its example
tests pass against the merged tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SoM3JLf877P788wVA5Ph4j
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants