Skip to content

Bootstrap workflows with the kernel-selected identity - #41

Merged
Shooksie merged 1 commit into
mainfrom
fix/task-1072-one-id
Jul 28, 2026
Merged

Bootstrap workflows with the kernel-selected identity#41
Shooksie merged 1 commit into
mainfrom
fix/task-1072-one-id

Conversation

@Shooksie

Copy link
Copy Markdown
Contributor

What changed

  • Add execute --new-workflow-id for an idempotent fresh workflow bootstrap.
  • Reject simultaneous fresh and resume IDs.
  • Create the durable journal row through run_with_id when the daemon supplies an ID.
  • Keep the stdio plugin wire behavior unchanged.

Why

The queue and runner previously minted independent UUIDs, guaranteeing a split between the queue entry and durable workflow journal for daemon-dispatched work.

Impact

The runner can now create or reconcile the exact workflow ID selected before queue lease. This runner release must precede the Animus release that emits the new flag.

Validation

  • Full cargo test: 293 passed, 5 known ignored, 0 failed
  • New argument regressions passed
  • git diff --check

@animus-launchapp-gitprovider animus-launchapp-gitprovider Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: APPROVE

No blocking findings. The new --new-workflow-id path is kept distinct from resume semantics, rejects ambiguous simultaneous IDs, propagates the kernel-selected ID into startup events, and uses WorkflowServiceApi::run_with_id while leaving the stdio request path unchanged. The focused parser regressions cover acceptance and mutual exclusion, and the Rust quality gate completed successfully.

What is good: the diff is small and release-order aware; it addresses the queue/journal identity split at the exact direct-execution boundary without changing the public plugin wire contract.

@Shooksie
Shooksie marked this pull request as ready for review July 28, 2026 08:38
@Shooksie
Shooksie merged commit 60e5033 into main Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant