Repository navigation
Add MellonSignAuthnRequest directive for AuthnRequest signing - #159
Open
sensei-hacker wants to merge 3 commits into
Open
sensei-hacker wants to merge 3 commits into
sensei-hacker wants to merge 3 commits into
Conversation
Adds a new 'MellonSignAuthnRequest on|off' config directive (default off) that sets LASSO_PROFILE_SIGNATURE_HINT_FORCE before building the AuthnRequest. This is needed for IdPs such as PingOne that require signed requests when consent:Implied is present, even though this is not mandated by the SAML spec. Does not affect the existing ECP signing path.
simo5
reviewed
Aug 5, 2026
simo5
left a comment
simo5
left a comment
Member
There was a problem hiding this comment.
looks reasonable but I think naming need changing to make it clear what it does
| int send_expect_header; | ||
|
|
||
| /* Force signing of AuthnRequests (MellonSignAuthnRequest). */ | ||
| int sign_authn_request; |
Member
There was a problem hiding this comment.
maybe call this force_sign_auth_request, given it triggers LASSO_PROFILE_SIGNATURE_HINT_FORCE ?
| return NULL; | ||
| } | ||
|
|
||
|
|
| ), | ||
|
|
||
| AP_INIT_FLAG( | ||
| "MellonSignAuthnRequest", |
Member
There was a problem hiding this comment.
call it MellonForceSignAuthnRequest ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata generated by the script says that Authn requests will be signed. But then they normally aren't.
Adds a new (optional) directive:
MellonSignAuthnRequest on|off
(default off) that sets LASSO_PROFILE_SIGNATURE_HINT_FORCE before building the AuthnRequest. This is needed for IdPs such as PingOne that require signed requests when consent:Implied is present, even though this is not mandated by the SAML spec. Does not affect the existing ECP signing path.