Repository navigation
fix(tests): fix flaky thread-link popup and timeline focus tests - #688
Merged
lastobelus merged 2 commits intoNov 10, 2026
Merged
Conversation
Close custom-protocol popup targets only after source input dispatch finishes. Keep keyboard focus coverage inside the visible browser area, wait for interactive rows, and click explicit viewport padding. Carry-Group: incubator Carry-Observation: Feature-specific Browser thread-link and conversation focus regressions stay with their Incubator features.
Deliver an uncommitted closed popup through the controlled event fixture and assert its closed state when interception receives it. Carry-Group: incubator
lastobelus
marked this pull request as ready for review
November 10, 2026 02:14
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
deleted the
lastcode/fix-thread-link-and-timeline-flaky-tests
branch
November 10, 2026 02:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests fail intermittently in CI. This fixes both at the cause. There is no quarantine, longer timeout, retry, sleep or frame wait. Only two test files change and production behavior is unchanged.
🔗
ThreadLinkNavigation.test.ts(popup click stalls)#popupclick stalls after the button is visible, enabled and stable (CI #42732216310, #42725878203).Target.targetCreatedhandler closed the uninitialized custom-protocol target immediately. That happened in the middle of the source window'swindow.openinput dispatch, so the click never finished.locator.clickcompletes.⌨️
MessagesTimeline.browser.test.tsx(focus/keyboard test){x:100,y:1}click could land on virtual row content or controls instead of blank viewport.scrollTop > 0can happen before the rows are interactive.min(600px, 100vh).pointerEvents: auto.📊 Evidence
Repeat runs. I used a temporary serial repeat harness, removed before commit.
This is repeated-run evidence, not a deterministic forced-order reproduction.
CI history. Of 100 recent CI runs, 13 failed (27 succeeded, 52 were cancelled, 7 skipped and 1 was still running).
Checks.
check:changed origin/lastcode/mainpassed format, lint, knip, GraphQL, the typechecks and 3 selected test files.ConnectionTransientErrorenvironment-discovery warnings still appear in passing focused runs. I made no connection-code change because nothing here justified one.ResizeObservererror in the supplied CI output belongs to the following rendered-height test, which passed.Both test files belong to Incubator. Each of the two source commits has
Carry-Group: incubator.Local review: 2 rounds with gpt-6.1-terra (xhigh) and Claude Opus 5.5 (high), approved.
Implemented by GPT-6.1 Sol (xhigh) in the Codex harness.