Repository navigation
fix: normalize MCP tool results - #31
Merged
Merged
Conversation
Handle native and MCP result shapes explicitly and warn when a non-null result is unrecognized. Refs: langfuse#22
Azther0z
force-pushed
the
fix/mcp-tool-results
branch
from
August 19, 2026 15:30
2dab061 to
bf45e8f
Compare
bezbac
self-requested a review
August 20, 2026 08:52
Member
|
Thanks for the PR @Azther0z! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #22, where MCP tool results were exported as
{}.OpenCode supplies different result shapes:
{ title, output, metadata, attachments }{ content: [...] }The hook now normalizes these shapes:
For example, a standard MCP text part such as
{ type: "text", text: "Search result" }is recorded as"Search result". Non-text parts are represented by markers such as"[image]"or"[resource]", matching the content-part types handled byOpenCode's MCP tool processing.
Verification
pnpm installpnpm run formatpnpm run buildpnpm run test:integrationFixes: #22
Assisted-by: OpenCode