Repository navigation
Enqueue observed WAL backlog before a full stats scan completes - #458
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 22, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hot table discovered early in a stats scan currently waits for every remaining table to finish before the merge sweep can see its pending WAL. On one production master, completed scans averaged about 92 minutes; this is a discovery delay independent of the separate legacy-worker admission blocker.
Consume each completed observation immediately and submit eligible targets to the existing durable merge queue. Incremental observations also qualify because they recount pending WAL. Preserve automatic-merge disablement, canonical deduplication, target encoding and all existing execution/ownership rules. Each scan can admit at most 256 new tasks and spend at most 10 seconds on queue admission, with a 2-second individual bound. An ambiguous queue error stops early admission for that round while observation and snapshot publication continue.
Validation: formatting and diff checks pass. Three real isolated-etcd regressions cover enqueue before a blocked observation completes, disablement/threshold/deduplication/budgets, and queue failure preserving the entire scan result. The final committed source passed all 18 scanner tests, including the three isolated-etcd regressions (0 failed or ignored); its commit and diff fingerprint stayed unchanged throughout the run. CI is running.
This adds no executor pool or rollout mode. It does not resolve historical unfenced requests, authorize replacement of an old writer, or bypass
core_not_readyin the external recovery controller. It is separate from the already-building #454/#456 release.