Repository navigation
fix: avoid same-store merge read-lock and memory-budget deadlock - #433
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 21, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two concurrent merges on one resident store can deadlock: the first retains its merge-memory reservation and waits for the store write lock to commit; the second holds a store read lock while waiting for that same memory. A real local GenericStore regression running concurrent count-triggered and cleanup merges with a 1 MiB total budget times out on the unmodified server.
Add one merge-admission mutex per resident store. Every rollout/generic HTTP merge and both sweeper paths clone it under a short read lock, drop that read guard, then await admission and retain it through preparation and commit. Ingestion, reads, compaction and other tables do not acquire this mutex. Distributed ownership, writer epochs, commit validation and the process memory limit are unchanged. Independently opened store handles and SDK callers still require their existing coordination; this is not a new takeover mechanism.
Validation:
coreandserver, all targets) passes, and CI Clippy is also green. The remaining full Rust/coverage CI is still running.