Repository navigation
fix: enqueue resident WAL continuation after successful completion - #432
Merged
Merged
Conversation
beinan
marked this pull request as ready for review
October 21, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful bounded resident WAL merge publishes durable continuation demand, but its next task currently waits for the 15-second request scan. Short passes can spend most of their time between tasks: an isolated two-writer Azure fixture reclaimed 45 of 80 generations in 330 seconds across 21 successful passes.
After a successful resident task durably completes and releases its claim, read that target’s existing demand and enqueue through the normal queue, deduplication and revision-checked acknowledgement. Failed work or completion, legacy tasks, and absent demand do not immediately enqueue another task. The periodic recovery scan handles failures and crashes. The change adds one targeted read per successful resident completion and preserves normal execution permits and table ownership.
Validation:
cargo fmtandgit diff --checkpass. Self-review covered completion before enqueue, per-target reads, queue fairness, revision checks and durable recovery. The existing compaction-turn fairness test also passed, and CI Clippy is green. Three further real-etcd ownership/demand regressions passed (demand while running, expired claim replacement, and fenced new-table demand). Local Clippy 1.96.1 flags two unchanged baselinenonminimal_boolexpressions; the full CI job uses Rust 1.99.1 and passes on this exact head. No local Clippy pass is claimed.